From: David Gibson <david@gibson.dropbear.id.au>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN
Date: Tue, 20 Nov 2012 09:48:23 +1100 [thread overview]
Message-ID: <20121119224823.GC18362@truffula.fritz.box> (raw)
In-Reply-To: <69634422-E5DA-48E6-807D-5C0333424EB9@suse.de>
On Mon, Nov 19, 2012 at 05:26:45PM +0100, Alexander Graf wrote:
>
> On 13.11.2012, at 03:46, David Gibson wrote:
>
> > Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models
> > to represent a TLB entry contains a hwaddr. That works reasonably for now,
> > but is troublesome for saving the state, which we'll want to do in future.
> > hwaddr is a large enough type to contain a physical address for any
> > supported machine - and can thus, in theory at least, vary depending on
> > what machines are enabled other than the one we're actually using right
> > now (though in fact it doesn't for ppc). This makes it unsuitable for
> > describing in vmstate.
> >
> > This patch therefore changes ppcemb_tlb_t to use a fixed 64-bit integer
> > which we know is sufficient for all the machines which use this structure.
>
> hwaddr is always defined to 64bit by now.
I know, but there aren't state save helpers for hwaddr, and there are
objections to creating them.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-11-19 22:50 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 2:46 [Qemu-devel] [0/12] Pending pseries patches David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 01/12] pseries: Fix incorrect initialization of interrupt controller David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 02/12] pseries: Use #define for XICS base irq number David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 03/12] pseries: Move XICS initialization before cpu initialization David Gibson
2012-11-19 16:22 ` Alexander Graf
2012-11-19 19:54 ` Benjamin Herrenschmidt
2012-11-19 22:47 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2012-11-20 9:26 ` Alexander Graf
2012-11-21 1:10 ` David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 04/12] pseries: Return the token when we register an RTAS call David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 05/12] pseries: Allow RTAS tokens without a qemu handler David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 06/12] pseries: Add tracepoints to the XICS interrupt controller David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 07/12] pseries: Split xics irq configuration from state information David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN David Gibson
2012-11-19 16:26 ` Alexander Graf
2012-11-19 22:48 ` David Gibson [this message]
2012-11-20 9:29 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2012-11-20 9:53 ` Peter Maydell
2012-11-20 9:55 ` Alexander Graf
2012-11-21 1:14 ` David Gibson
2012-11-21 1:48 ` Alexander Graf
2012-11-21 1:56 ` David Gibson
2012-11-21 10:07 ` Alexander Graf
2012-11-13 2:46 ` [Qemu-devel] [PATCH 09/12] pseries: Implement PAPR NVRAM David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 10/12] pseries: Update SLOF for NVRAM support David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 11/12] pseries: Fix bug in PCI MSI allocation David Gibson
2012-11-13 2:47 ` [Qemu-devel] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges David Gibson
2012-11-19 16:34 ` Alexander Graf
2012-11-19 22:51 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2012-11-20 9:27 ` Alexander Graf
2012-11-20 12:26 ` Michael S. Tsirkin
2012-11-21 0:57 ` David Gibson
2012-11-21 11:34 ` Michael S. Tsirkin
2012-11-21 12:36 ` David Gibson
2012-11-21 13:13 ` Michael S. Tsirkin
2012-11-21 13:21 ` David Gibson
2012-11-21 13:27 ` Alexander Graf
2012-11-21 15:27 ` Michael S. Tsirkin
2012-11-22 2:27 ` David Gibson
2012-11-22 7:23 ` Michael S. Tsirkin
2012-11-22 11:27 ` Alexander Graf
2012-11-22 11:39 ` Michael S. Tsirkin
2012-11-23 4:13 ` David Gibson
2012-11-23 10:53 ` Michael S. Tsirkin
2012-11-23 12:59 ` David Gibson
2012-11-23 13:44 ` Michael S. Tsirkin
2012-11-23 13:44 ` Alexander Graf
2012-11-23 14:01 ` Michael S. Tsirkin
2012-11-23 14:03 ` Alexander Graf
2012-11-23 14:18 ` Michael S. Tsirkin
2012-11-23 14:27 ` Alexander Graf
2012-11-25 23:24 ` David Gibson
2012-11-21 15:20 ` Michael S. Tsirkin
2012-11-21 5:00 ` David Gibson
2012-11-21 10:09 ` Alexander Graf
2012-11-21 11:40 ` Michael S. Tsirkin
2012-11-19 16:35 ` [Qemu-devel] [0/12] Pending pseries patches Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119224823.GC18362@truffula.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.