From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: David Dajun Chen <dchen@diasemi.com>,
Ashish Jangam <ashish.jangam@kpitcummins.com>,
Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFT] regulator: da9055: Fix return wrong selector in da9055_regulator_get_voltage_sel
Date: Tue, 20 Nov 2012 13:51:21 +0900 [thread overview]
Message-ID: <20121120045119.GG4483@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1353386347.19552.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
On Tue, Nov 20, 2012 at 12:39:07PM +0800, Axel Lin wrote:
> We do "selector += info->volt.v_offset" in da9055_regulator_set_voltage_bits()
> to take care of voltage range that does not start with 0 offset.
> Thus in da9055_regulator_get_voltage_sel() we should do corresponding
> "sel -= volt.v_offset" before returning selector.
> Otherwise, we pass wrong selector for list_voltage callback.
No, we should just be using raw register values as the selectors and
fixing this in list_voltage() by returning 0 for invalid selectors.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-11-20 4:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 4:39 [PATCH RFT] regulator: da9055: Fix return wrong selector in da9055_regulator_get_voltage_sel Axel Lin
2012-11-20 4:51 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120045119.GG4483@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=axel.lin@ingics.com \
--cc=dchen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.