From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: Re: DVS regulator drivers
Date: Tue, 20 Nov 2012 17:27:44 +0900 [thread overview]
Message-ID: <20121120082741.GV10560@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1211200856380.21420@axis700.grange>
[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]
On Tue, Nov 20, 2012 at 09:17:46AM +0100, Guennadi Liakhovetski wrote:
> On Tue, 20 Nov 2012, Mark Brown wrote:
> > Please don't invent terminology or repurpose existing terminology like
> > this, it's just confusing - obvious essentially all regulators covered
> > by the regulator API support voltage scaling which is the usual meaning
> > of DVS.
> Right, sorry, a more precise term would be a "pin-selectable DVS," right?
Yup.
> > Can you be more specific about your concern here? The above code does
> > exactly what the comment says, it will set the selector it just picked.
> Your patch fixes exactly the problem, that I was pointing at, thanks.
Oh, right. It sounded like you also had some concern with on_vsel which
I couldn't figure out.
> > You did spot one bug (I think due to bitrot) which I just fixed but in
> > general I've just TLDRed this as it's a bit unclear what you're trying
> > to say here, can you be a bit more concise here? I'm not sure if
> > there's a general point or if it's specific code issues?
> Sorry, let's try again. Just to bring back the "too long and a bit unclear
> part:"
It was the mail as a whole - I spent less time on lp872x since I don't
have any access to the hardware either.
> where dvs is platform data, i.e., all parameters are constant. So,
> lp872x_set_dvs() never switches anything, and in fact it could just have
> been called just once from initialisation to set the GPIO. This also
> means, that only one context - either SEL_V1 or SEL_V2 is used.
I think you're right there.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-20 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 11:52 DVS regulator drivers Guennadi Liakhovetski
2012-11-20 1:05 ` Mark Brown
2012-11-20 8:17 ` Guennadi Liakhovetski
2012-11-20 8:27 ` Mark Brown [this message]
2012-11-20 10:02 ` Guennadi Liakhovetski
2012-11-20 10:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120082741.GV10560@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.