From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:50216 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752434Ab2KTKO5 (ORCPT ); Tue, 20 Nov 2012 05:14:57 -0500 Date: Tue, 20 Nov 2012 05:14:53 -0500 From: Christoph Hellwig To: Zheng Liu Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, linux-btrfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, yan@linux.vnet.ibm.com, Zheng Liu Subject: Re: [PATCH 0/4][RFC] remove duplicated check from ext4, xfs, btrfs, and ocfs2 Message-ID: <20121120101452.GA692@infradead.org> References: <1353403785-3489-1-git-send-email-wenqing.lz@taobao.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1353403785-3489-1-git-send-email-wenqing.lz@taobao.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Tue, Nov 20, 2012 at 05:29:41PM +0800, Zheng Liu wrote: > Hi all, > > This patch series tries to remove a sanity check in fallocate from specific > filesystems because vfs has already checked it. > > I am not very familiar with why we need to do this duplicated check. Please let > me know if I miss something. Each filesystem driver checks to see if a flag that it doesn't support gets passed down. This was done with the intention that we can add new flags to the VFS without having to update every filesystem. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qAKACol2138276 for ; Tue, 20 Nov 2012 04:12:50 -0600 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id HjG5oGzXDHcTMuUo (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Tue, 20 Nov 2012 02:14:58 -0800 (PST) Date: Tue, 20 Nov 2012 05:14:53 -0500 From: Christoph Hellwig Subject: Re: [PATCH 0/4][RFC] remove duplicated check from ext4, xfs, btrfs, and ocfs2 Message-ID: <20121120101452.GA692@infradead.org> References: <1353403785-3489-1-git-send-email-wenqing.lz@taobao.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1353403785-3489-1-git-send-email-wenqing.lz@taobao.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Zheng Liu Cc: xfs@oss.sgi.com, yan@linux.vnet.ibm.com, linux-btrfs@vger.kernel.org, Zheng Liu , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com On Tue, Nov 20, 2012 at 05:29:41PM +0800, Zheng Liu wrote: > Hi all, > > This patch series tries to remove a sanity check in fallocate from specific > filesystems because vfs has already checked it. > > I am not very familiar with why we need to do this duplicated check. Please let > me know if I miss something. Each filesystem driver checks to see if a flag that it doesn't support gets passed down. This was done with the intention that we can add new flags to the VFS without having to update every filesystem. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Tue, 20 Nov 2012 05:14:53 -0500 Subject: [Ocfs2-devel] [PATCH 0/4][RFC] remove duplicated check from ext4, xfs, btrfs, and ocfs2 In-Reply-To: <1353403785-3489-1-git-send-email-wenqing.lz@taobao.com> References: <1353403785-3489-1-git-send-email-wenqing.lz@taobao.com> Message-ID: <20121120101452.GA692@infradead.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Zheng Liu Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, linux-btrfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, yan@linux.vnet.ibm.com, Zheng Liu On Tue, Nov 20, 2012 at 05:29:41PM +0800, Zheng Liu wrote: > Hi all, > > This patch series tries to remove a sanity check in fallocate from specific > filesystems because vfs has already checked it. > > I am not very familiar with why we need to do this duplicated check. Please let > me know if I miss something. Each filesystem driver checks to see if a flag that it doesn't support gets passed down. This was done with the intention that we can add new flags to the VFS without having to update every filesystem.