From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: arm: mvebu: Various mvebu clock fixes/improvements
Date: Tue, 20 Nov 2012 10:40:42 +0100 [thread overview]
Message-ID: <20121120104042.224e51a5@skate> (raw)
In-Reply-To: <20121119182701.GS14643@lunn.ch>
Andrew,
On Mon, 19 Nov 2012 19:27:01 +0100, Andrew Lunn wrote:
> > In summary:
> >
> > * Patch 1 fixes a real problem: the gating clocks are not registered
> > on Armada 370/XP.
> >
> > * Patch 2, 3, 5 and 6 are more cosmetic patches, but I think they are
> > good to have.
> >
> > * Patch 4 implements a fix that we've been discussing: moving the
> > Armada XP CPU clocks down to the individual armada-xp-mv78xxx.dtsi
> > files.
> >
> > * Patch 7 fixes the references to the SATA clocks on Armada
> > 370/XP. Without this patch, Armada 370 currently hangs at boot when
> > trying to initialize SATA.
>
> Hi Thomas
>
> You probably want patch 1 last. Anybody bisecting this changeset if
> going to have a hung 370/XP.
Unfortunately, I don't think putting patch 1 last will work either: in
patch 7, I change the SATA clocks to point to the gating clocks. So if
patch 1 is not there, those clocks do not exist and the driver fails to
clk_get() those clocks.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-11-20 9:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 16:52 arm: mvebu: Various mvebu clock fixes/improvements Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 1/7] clk: mvebu: init all mvebu clock types from mvebu_clocks_init() Thomas Petazzoni
2012-11-19 18:25 ` Andrew Lunn
2012-11-19 18:44 ` Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 2/7] clk: mvebu: move clk-cpu compatible strings into the clk-cpu driver Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 3/7] clk: mvebu: rename mvebu_clk_gating_init() to mvebu_gating_clk_init() Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 4/7] arm: mvebu: move DT cpu clock nodes to the Armada XP specific .dtsi Thomas Petazzoni
2012-11-19 18:38 ` Andrew Lunn
2012-11-19 18:50 ` Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 5/7] clk: mvebu: rename *-core-clocks to *-core-clock Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 6/7] clk: mvebu: rename armada-xp-cpu-clockctrl to armada-xp-cpu-clock Thomas Petazzoni
2012-11-19 16:52 ` [PATCH 7/7] arm: mvebu: fix SATA clocks on Armada 370/XP Thomas Petazzoni
2012-11-19 18:27 ` arm: mvebu: Various mvebu clock fixes/improvements Andrew Lunn
2012-11-19 18:46 ` Thomas Petazzoni
2012-11-20 9:40 ` Thomas Petazzoni [this message]
2012-11-20 9:43 ` Andrew Lunn
2012-11-20 10:06 ` Thomas Petazzoni
2012-11-20 10:50 ` Thomas Petazzoni
2012-11-20 16:22 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120104042.224e51a5@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.