From: "Daniel P. Berrange" <berrange@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, khoa@us.ibm.com,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
asias@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 8/8] virtio-blk: add x-data-plane=on|off performance feature
Date: Tue, 20 Nov 2012 14:34:44 +0000 [thread overview]
Message-ID: <20121120143444.GK3461@redhat.com> (raw)
In-Reply-To: <20121120135002.GA28489@stefanha-thinkpad.redhat.com>
On Tue, Nov 20, 2012 at 02:50:02PM +0100, Stefan Hajnoczi wrote:
> On Tue, Nov 20, 2012 at 12:37:08PM +0000, Daniel P. Berrange wrote:
> > On Tue, Nov 20, 2012 at 01:31:52PM +0100, Stefan Hajnoczi wrote:
> > > The virtio-blk-data-plane feature is easy to integrate into
> > > hw/virtio-blk.c. The data plane can be started and stopped similar to
> > > vhost-net.
> > >
> > > Users can take advantage of the virtio-blk-data-plane feature using the
> > > new -device virtio-blk-pci,x-data-plane=on property.
> > >
> > > The x-data-plane name was chosen because at this stage the feature is
> > > experimental and likely to see changes in the future.
> >
> > Can you give some indication of how it is likely to change, since
> > this has a bearing on any libvirt use of this feature ?
>
> The following expectations:
>
> 1. This is an experimental feature. It can be enabled through libvirt
> using <qemu:commandline>.
>
> 2. There is ongoing work to break down the global mutex in QEMU, which
> will allow virtio-blk-data-plane functionality to become the
> virtio-blk emulation default. At that point no command-line options
> will be necessary (migration and image formats will be supported).
>
> So I think there's no need for libvirt to do anything here.
Thanks for clarifying, Kevin / Stefan. Based on this info, we'll do nothing
with this in libvirt, in the expection that it'll become the default when
QEMU is ready for it.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
prev parent reply other threads:[~2012-11-20 14:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 12:31 [Qemu-devel] [PATCH v2 0/8] virtio: virtio-blk data plane Stefan Hajnoczi
2012-11-20 12:31 ` [Qemu-devel] [PATCH v2 1/8] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane Stefan Hajnoczi
2012-11-20 12:31 ` [Qemu-devel] [PATCH v2 2/8] configure: add CONFIG_VIRTIO_BLK_DATA_PLANE Stefan Hajnoczi
2012-11-21 18:17 ` mdroth
2012-11-21 18:29 ` Stefan Hajnoczi
2012-11-21 18:45 ` mdroth
2012-11-20 12:31 ` [Qemu-devel] [PATCH v2 3/8] dataplane: add host memory mapping code Stefan Hajnoczi
2012-11-20 18:24 ` Don Koch
2012-11-21 7:59 ` Stefan Hajnoczi
2012-11-26 15:31 ` Don Koch
2012-11-20 12:31 ` [Qemu-devel] [PATCH v2 4/8] dataplane: add virtqueue vring code Stefan Hajnoczi
2012-11-20 12:31 ` [Qemu-devel] [PATCH v2 5/8] dataplane: add event loop Stefan Hajnoczi
2012-11-20 12:31 ` [Qemu-devel] [PATCH v2 6/8] dataplane: add Linux AIO request queue Stefan Hajnoczi
2012-11-20 12:31 ` [Qemu-devel] [PATCH v2 7/8] dataplane: add virtio-blk data plane code Stefan Hajnoczi
2012-11-20 13:04 ` Michael S. Tsirkin
2012-11-20 13:54 ` Stefan Hajnoczi
2012-11-20 12:31 ` [Qemu-devel] [PATCH v2 8/8] virtio-blk: add x-data-plane=on|off performance feature Stefan Hajnoczi
2012-11-20 12:37 ` Daniel P. Berrange
2012-11-20 12:53 ` Kevin Wolf
2012-11-20 13:50 ` Stefan Hajnoczi
2012-11-20 14:34 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120143444.GK3461@redhat.com \
--to=berrange@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=asias@redhat.com \
--cc=khoa@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.