From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Tue, 20 Nov 2012 18:46:08 +0100 Subject: [U-Boot] [PATCH v4 2/7] part:efi: Move part_efi.h file to ./include In-Reply-To: <20121119204141.GD9467@oliver-linux> References: <1345795995-24656-1-git-send-email-l.majewski@samsung.com> <1352452938-2375-1-git-send-email-p.wilczek@samsung.com> <1352452938-2375-3-git-send-email-p.wilczek@samsung.com> <50AA88BA.4020601@wwwdotorg.org> <20121119204141.GD9467@oliver-linux> Message-ID: <20121120184608.6c5a29f2@amdc308.digital.local> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, > On Mon, Nov 19, 2012 at 12:30:02PM -0700, Stephen Warren wrote: > > On 11/09/2012 02:22 AM, Piotr Wilczek wrote: > > > From: Lukasz Majewski > > > > > > This move is necessary to export gpt header and GPT partition > > > entries to be used with other commands or subsystems (like DFU in > > > the future) Additionally the part_efi.h file has been cleaned-up > > > to supress checkpatch's warnings. > > > > > {disk => include}/part_efi.h | 0 > > > > I can understand the "gpt" command perhaps needing access to the > > GPT-specific types, but I would hope that anything DFU-related > > would be using types from include/part.h; I don't imagine that DFU > > would need to know anything about GPT at all? > > Indeed. DFU must not get coupled to GPT (or for that matter, > partitions) in the general code. There should be "DFU write to a > GPT-using backing store" code, if that's needed. Not all eMMC would > be GPT-using, for example. > Yes, the commit description is now a bit misleading. The idea here is to have access to part_efi.h from gpt command. DFU will use higher level of abstraction (as Stephen once suggested). -- Best regards, Lukasz Majewski Samsung Poland R&D Center | Linux Platform Group