From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx166.postini.com [74.125.245.166]) by kanga.kvack.org (Postfix) with SMTP id 852436B002B for ; Wed, 21 Nov 2012 03:12:45 -0500 (EST) Received: by mail-ee0-f41.google.com with SMTP id d41so4804778eek.14 for ; Wed, 21 Nov 2012 00:12:44 -0800 (PST) Date: Wed, 21 Nov 2012 09:12:39 +0100 From: Ingo Molnar Subject: Re: [PATCH, v2] mm, numa: Turn 4K pte NUMA faults into effective hugepage ones Message-ID: <20121121081239.GA23603@gmail.com> References: <1353291284-2998-1-git-send-email-mingo@kernel.org> <20121119162909.GL8218@suse.de> <20121119191339.GA11701@gmail.com> <20121119211804.GM8218@suse.de> <20121119223604.GA13470@gmail.com> <20121120071704.GA14199@gmail.com> <20121120152933.GA17996@gmail.com> <20121120160918.GA18167@gmail.com> <50ABB06A.9000402@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50ABB06A.9000402@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: Linus Torvalds , David Rientjes , Mel Gorman , Linux Kernel Mailing List , linux-mm , Peter Zijlstra , Paul Turner , Lee Schermerhorn , Christoph Lameter , Andrew Morton , Andrea Arcangeli , Thomas Gleixner , Johannes Weiner , Hugh Dickins * Rik van Riel wrote: > >+} > >+ > >+/* > >+ * Add a simple loop to also fetch ptes within the same pmd: > >+ */ > > That's not a very useful comment. How about something like: > > /* > * Also fault over nearby ptes from within the same pmd and vma, > * in order to minimize the overhead from page fault exceptions > * and TLB flushes. > */ There's no TLB flushes here. But I'm fine with the other part so I've updated the comment to say: /* * Also fault over nearby ptes from within the same pmd and vma, * in order to minimize the overhead from page fault exceptions: */ Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752878Ab2KUIMt (ORCPT ); Wed, 21 Nov 2012 03:12:49 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:49323 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904Ab2KUIMr (ORCPT ); Wed, 21 Nov 2012 03:12:47 -0500 Date: Wed, 21 Nov 2012 09:12:39 +0100 From: Ingo Molnar To: Rik van Riel Cc: Linus Torvalds , David Rientjes , Mel Gorman , Linux Kernel Mailing List , linux-mm , Peter Zijlstra , Paul Turner , Lee Schermerhorn , Christoph Lameter , Andrew Morton , Andrea Arcangeli , Thomas Gleixner , Johannes Weiner , Hugh Dickins Subject: Re: [PATCH, v2] mm, numa: Turn 4K pte NUMA faults into effective hugepage ones Message-ID: <20121121081239.GA23603@gmail.com> References: <1353291284-2998-1-git-send-email-mingo@kernel.org> <20121119162909.GL8218@suse.de> <20121119191339.GA11701@gmail.com> <20121119211804.GM8218@suse.de> <20121119223604.GA13470@gmail.com> <20121120071704.GA14199@gmail.com> <20121120152933.GA17996@gmail.com> <20121120160918.GA18167@gmail.com> <50ABB06A.9000402@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50ABB06A.9000402@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Rik van Riel wrote: > >+} > >+ > >+/* > >+ * Add a simple loop to also fetch ptes within the same pmd: > >+ */ > > That's not a very useful comment. How about something like: > > /* > * Also fault over nearby ptes from within the same pmd and vma, > * in order to minimize the overhead from page fault exceptions > * and TLB flushes. > */ There's no TLB flushes here. But I'm fine with the other part so I've updated the comment to say: /* * Also fault over nearby ptes from within the same pmd and vma, * in order to minimize the overhead from page fault exceptions: */ Thanks, Ingo