All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] DEBUG: fix relocation address
Date: Wed, 21 Nov 2012 09:24:41 +0100	[thread overview]
Message-ID: <20121121082441.41B532003CF@gemini.denx.de> (raw)
In-Reply-To: <1353476660-18018-2-git-send-email-koba@kmckk.co.jp>

Dear Tetsuyuki Kobayashi,

In message <1353476660-18018-2-git-send-email-koba@kmckk.co.jp> you wrote:
> U-Boot from NOR flash relocates itself to RAM erea. The relocation address is
> calaculated at runtime to get maxium contiguous space to load kernel. So it may
> vary after code changed. In the early debug phase it would be easier to handle
> if the relocation address does not change.
> This patch sets relocation address to fixed address specified by
> CONFIG_DEBUG_RELOC_FIX_ADDR. If there is no enough space after
> CONFIG_DEBUG_RELOC_FIX_ADDR, it is ignored.
> patch to kzm9g.h is a example. CONFIG_DEBUG_RELOC_FIX_ADDR should be defined at
> each config file.
> 
> Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
> ---
>  arch/arm/lib/board.c    |    9 ++++++++-
>  include/configs/kzm9g.h |    4 ++++
>  2 files changed, 12 insertions(+), 1 deletion(-)

NAK for this patch for the general reasons outlined oin my summary
reply to the cover letter.

In addition:

- If this is supposed to be a RFC patch series, then please add the
  RFC part to ALL patches, not only to the cover letter.

- Any changes to basic infrastucture like this have to be done in a
  general, architecture-independent way.  Doing this for ARM only is
  not acceptable.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Confound these ancestors.... They've stolen our best ideas!"
- Ben Jonson

  reply	other threads:[~2012-11-21  8:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  5:44 [U-Boot] [PATCH 0/2] [RFC] DEBUG: relocate to fixed address Tetsuyuki Kobayashi
2012-11-21  5:44 ` [U-Boot] [PATCH 1/2] DEBUG: fix relocation address Tetsuyuki Kobayashi
2012-11-21  8:24   ` Wolfgang Denk [this message]
2012-11-21  5:44 ` [U-Boot] [PATCH 2/2] DEBUG: make u-boot_r which is linked for fixed " Tetsuyuki Kobayashi
2012-11-21  8:22 ` [U-Boot] [PATCH 0/2] [RFC] DEBUG: relocate to fixed address Wolfgang Denk
2012-11-27 22:22   ` Scott Wood
2012-11-27 23:36     ` Henrik Nordström
2012-11-28  9:24       ` Wolfgang Denk
2012-11-28  6:45     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121121082441.41B532003CF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.