From: Wolfgang Denk <wd@denx.de>
To: stefan.roese@gmail.com
Cc: Stefan Roese <sr@denx.de>, xenomai@xenomai.org
Subject: Re: [Xenomai] [PATCH v2] mpc5200: Add RTDM LPBFIFO driver and demo RTDM FPGA device driver
Date: Wed, 21 Nov 2012 10:09:13 +0100 [thread overview]
Message-ID: <20121121090913.B53842003CF@gemini.denx.de> (raw)
In-Reply-To: <1353481805-28850-1-git-send-email-stefan.roese@gmail.com>
Dear Stefan,
In message <1353481805-28850-1-git-send-email-stefan.roese@gmail.com> you wrote:
>
> This patch adds support for the RTDM LPB (LocalPlusBus) FIFO driver
> for the MPC5200. It will be used for DMA support in an RTDM FPGA
> device driver. This rt-fpga.c driver is a custom device driver,
> but might be useful for other developers as well. Thats why I
> included it here too.
...
> --- /dev/null
> +++ b/ksrc/drivers/mpc5200_dma/Config.in
> @@ -0,0 +1,10 @@
> +#
> +# Xenomai configuration for Linux v2.4
Linux v2.4 ???
I am pretty sure this driver will not run with a 2.4 Linux kenrel...
> +#define dbg(format, arg...) \
> + printk("%s (%d): " format, __func__, __LINE__, ##arg)
> +#else
> +#define dbg(format, arg...) \
> +do { \
> + if (0) \
> + printk("%s (%d): " format, __func__, __LINE__, ##arg); \
> +} while (0)
> +#endif
Why do you define your own (incomaptible to everything else) debug
facilities? Can you not rather use the existing kernel debug
macros?
> +#ifdef PRINT_READ_TIME
I see no translation happening anywhere between PRINT_READ_TIME and
CONFIG_XENO_DRIVERS_MPC5200_DMA_PRINT_READ_TIME - am I missing
something?
> +#ifdef NO_DMA
Ditto for NO_DMA versus CONFIG_XENO_DRIVERS_MPC5200_DMA_NO_DMA ?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"Evil does seek to maintain power by suppressing the truth."
"Or by misleading the innocent."
-- Spock and McCoy, "And The Children Shall Lead",
stardate 5029.5.
next prev parent reply other threads:[~2012-11-21 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 7:10 [Xenomai] [PATCH v2] mpc5200: Add RTDM LPBFIFO driver and demo RTDM FPGA device driver stefan.roese
2012-11-21 8:24 ` Jan Kiszka
2012-11-21 9:27 ` Stefan Roese
2012-11-22 19:58 ` Jan Kiszka
2012-11-23 7:18 ` Stefan Roese
2012-11-21 9:09 ` Wolfgang Denk [this message]
2012-11-21 9:28 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121090913.B53842003CF@gemini.denx.de \
--to=wd@denx.de \
--cc=sr@denx.de \
--cc=stefan.roese@gmail.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.