From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/i915: set the AVI VIC of the HDMI mode Date: Wed, 21 Nov 2012 16:47:42 +0100 Message-ID: <20121121154742.GA1026@avionic-0098.adnet.avionic-design.de> References: <1353512389-16261-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2105498229==" Return-path: In-Reply-To: <1353512389-16261-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2105498229== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 21, 2012 at 01:39:48PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni >=20 > We currently set "0" as the VIC value of the AVI InfoFrames. According > to the specs this should be fine and work for every mode, so to my > point of view we can't consider the current behavior as a bug. The > problem is that we recently received a bug report (Kernel bug #50371) > from a user that has an AV receiver that gives a black screen for any > mode with VIC set to 0. >=20 > So in order to make at least some modes work for him, this patch sets > the correct VIC number when sending AVI InfoFrames. We add a generic > drm function to calculate the VIC number and then call it from the > i915 driver. >=20 > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=3D50371 > Cc: Thierry Reding > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/drm_edid.c | 19 +++++++++++++++++++ > drivers/gpu/drm/drm_modes.c | 3 ++- > drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ > include/drm/drm_crtc.h | 4 +++- > 4 files changed, 26 insertions(+), 2 deletions(-) >=20 > Patch applies on top of Daniel's drm-intel-next-queued. I'm not sure who = exactly > is going to merge this (Dave or Daniel). >=20 > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index fadcd44..c57fc46 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -2062,3 +2062,22 @@ int drm_add_modes_noedid(struct drm_connector *con= nector, > return num_modes; > } > EXPORT_SYMBOL(drm_add_modes_noedid); > + > +/** > + * drm_mode_vic - return the CEA-861 VIC of a given mode > + * @mode: mode > + * > + * RETURNS: > + * The VIC number, 0 in case it's not a CEA-861 mode. > + */ > +uint8_t drm_mode_cea_vic(const struct drm_display_mode *mode) > +{ > + uint8_t i; > + > + for (i =3D 0; i < drm_num_cea_modes; i++) > + if (drm_mode_equal(mode, &edid_cea_modes[i])) > + return i + 1; > + > + return 0; > +} > +EXPORT_SYMBOL(drm_mode_cea_vic); Oh great, so I copied that table for nothing. Thanks for Cc'ing, I can reuse that in the HDMI infoframe series. Thierry --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQrPeeAAoJEN0jrNd/PrOhKpkP/28B9Xnw8TPHupRtvYmnhQX+ p427fv3WA12TPOMnvN8VaYTDhV4Dtm7GK1V/Ty6rq/r5mNUGYrBA0iBlIZkL2g0n c4ovunS/gqcsB3N9vsJxiNAy25Jk2KV6ivbpN+GqkLiIXOMJed5b27Jc9s1r778l YAMz2ruWVdDIccDb4fdJZpS/mYMDu8OIXO74uoLpEBY7TRFaAa0k1d1rt1IsX/3m guYAH91o4B2VUwBRZLLWbVXJ/oUNhrMRQ9pmVir07mXsdUwKCs4XxtI2Yf9leL5Y c0HCzy3JXQ+USRcyB5mK+HNKh9XY6ICg1mYAdmfdra9U6uXLHazyOLZoYXPgrze4 PzclMWoKUYr5pVXOuCzTiWlysJN4IHcMSXuzZTS7BOVYedYz4la5shtLkIFseZlo mlrllI3g0st43Ui0DdsiK9qzgRXNzglelJ9V1i2wTw2ePvuBmiFZxvnmv5WcQEPD EnPS+Y6scr7AzeyE/2zXDSoVFJRPjL+aTUH+nJ0dl2DFxNoWqvEg3MsWj6OByefD mCqXoWbyYj9VHc5WfQX1kRVStkS6DI+w40soVNZ0ks3rqKf7igV9NANxAuHWOtU/ +OdWi8YCawUVL2sCr7GI5nRgaMZ2NeE0z6//Su88QqDzOLi3qw+v3N9z2gyQvBt7 0ZNURBL6FLc8W4kTjoFR =6Hra -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j-- --===============2105498229== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============2105498229==--