From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Kirkwood: Update PCI-E fixup
Date: Wed, 21 Nov 2012 10:33:57 -0700 [thread overview]
Message-ID: <20121121173357.GC6406@obsidianresearch.com> (raw)
In-Reply-To: <20121121160555.0710e048@skate>
On Wed, Nov 21, 2012 at 04:05:55PM +0100, Thomas Petazzoni wrote:
> Dear Jason Gunthorpe,
>
> On Wed, 21 Nov 2012 00:19:06 -0700, Jason Gunthorpe wrote:
>
> > +/* The root complex has a hardwired class of PCI_CLASS_MEMORY_OTHER, when it
> > + is operating as a root complex this needs to be switched to
> > + PCI_CLASS_BRIDGE_HOST or Linux will errantly try to process the BAR's on
> > + the device. Decoding setup is handled by the orion code. */
>
> Sorry for this unique silly review comment, but this comment does not
> comply with the kernel CodingStyle for multicomments. It should be:
Ok! Though I'm surprised checkpatch didn't complain?
Jason
next prev parent reply other threads:[~2012-11-21 17:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 7:19 [PATCH] ARM: Kirkwood: Update PCI-E fixup Jason Gunthorpe
2012-11-21 15:05 ` Thomas Petazzoni
2012-11-21 17:33 ` Jason Gunthorpe [this message]
2012-11-21 17:44 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121173357.GC6406@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.