From: Greg KH <gregkh@linuxfoundation.org>
To: Rupesh Gujare <rgujare@ozmodevices.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, sachin.kamat@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c
Date: Wed, 21 Nov 2012 13:48:23 -0800 [thread overview]
Message-ID: <20121121214823.GA28532@kroah.com> (raw)
In-Reply-To: <50AD0EB4.5070307@ozmodevices.com>
On Wed, Nov 21, 2012 at 05:26:12PM +0000, Rupesh Gujare wrote:
> On 21/11/12 16:19, Dan Carpenter wrote:
> >When someone sends a patch there are a several possible responses:
> >1) Ack the patch.
> >2) Request that the submitter redo it. The downside is that no one
> > likes redoing patches.
> >3) Reject the patch.
> >4) Redo it yourself and say "Based on a patch from Sachin Kamat".
> > This isn't nice because everyone wants author credit.
> >5) Redo it and get permission from the original author to give them
> > author credit get their signed-off-by.
> >
> >
> Thanks Dan
>
> I will keep it in mind in future.
>
> Sachin,
>
> Are you interested in redoing (or sending sign-off ?) for this patch
> series ? I am more than happy to accept either.
Don't worry, I'll clean up the mess here...
next prev parent reply other threads:[~2012-11-22 20:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121120163513.GC4990@kroah.com>
2012-11-21 12:46 ` [V2 PATCH 0/3] staging : ozwpan: Remove NULL pointer check Rupesh Gujare
2012-11-21 12:46 ` [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c Rupesh Gujare
2012-11-21 13:05 ` Dan Carpenter
2012-11-21 13:42 ` Rupesh Gujare
2012-11-21 16:19 ` Dan Carpenter
2012-11-21 17:26 ` Rupesh Gujare
2012-11-21 21:48 ` Greg KH [this message]
2012-11-21 23:10 ` Rupesh Gujare
2012-11-21 23:14 ` Greg KH
2012-11-21 12:46 ` [V2 PATCH 2/3] staging: ozwpan: Remove redundant null check before kfree in ozproto.c Rupesh Gujare
2012-11-21 12:46 ` [V2 PATCH 3/3] staging: ozwpan: Remove redundant null check before kfree in ozhcd.c Rupesh Gujare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121214823.GA28532@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rgujare@ozmodevices.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.