From: Greg KH <gregkh@linuxfoundation.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
linux-kernel@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH 1/1] tty: vt: Remove redundant null check before kfree.
Date: Wed, 21 Nov 2012 15:00:57 -0800 [thread overview]
Message-ID: <20121121230057.GA29095@kroah.com> (raw)
In-Reply-To: <50AD5916.3030604@suse.cz>
On Wed, Nov 21, 2012 at 11:43:34PM +0100, Jiri Slaby wrote:
> On 11/21/2012 03:46 PM, Greg KH wrote:
> > On Wed, Nov 21, 2012 at 10:49:07AM +0530, Sachin Kamat wrote:
> >> --- a/drivers/tty/vt/consolemap.c
> >> +++ b/drivers/tty/vt/consolemap.c
> >> @@ -410,10 +410,8 @@ static void con_release_unimap(struct uni_pagedir *p)
> >> kfree(p->inverse_translations[i]);
> >> p->inverse_translations[i] = NULL;
> >> }
> >> - if (p->inverse_trans_unicode) {
> >> - kfree(p->inverse_trans_unicode);
> >> - p->inverse_trans_unicode = NULL;
> >> - }
> >> + kfree(p->inverse_trans_unicode);
> >> + p->inverse_trans_unicode = NULL;
> >
> > kfree with NULL is a no-op, but the line after that just caused a kernel
> > crash if it was NULL, so I can't accept this type of thing.
>
> Greg, I'm not sure -- what do you mean here? The change actually looks
> fine to me... We do not dereference p->inverse_trans_unicode there.
If we never dereference it, why is it being set to NULL?
greg k-h
next prev parent reply other threads:[~2012-11-22 21:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 5:19 [PATCH 1/1] tty: vt: Remove redundant null check before kfree Sachin Kamat
2012-11-21 14:46 ` Greg KH
2012-11-21 14:51 ` Sachin Kamat
2012-11-21 15:16 ` Greg KH
2012-11-21 15:29 ` Sachin Kamat
2012-11-21 16:54 ` Greg KH
2012-11-21 22:43 ` Jiri Slaby
2012-11-21 23:00 ` Greg KH [this message]
2012-11-21 23:17 ` Jiri Slaby
2012-11-22 0:38 ` Greg KH
2012-11-22 5:19 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121230057.GA29095@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.