Re: [PATCH] read cfi device id according the bus width

From: 张忠山 <zzs213@126.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH] read cfi device id according the bus width
Date: Thu, 22 Nov 2012 14:26:17 +0800	[thread overview]
Message-ID: <20121122062616.GD3022@greatfirst.com> (raw)
In-Reply-To: <20121122061438.GR8327@game.jcrosoft.org>

In message <20121122061438.GR8327@game.jcrosoft.org> Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 14:01 Thu 22 Nov     , 张忠山 wrote:
> > Signed-off-by: 张忠山 <zzs213@126.com>
> > ---
> >  drivers/nor/cfi_flash_amd.c |    7 +++++--
> >  1 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/nor/cfi_flash_amd.c b/drivers/nor/cfi_flash_amd.c
> > index 45c59b9..3ab4be0 100644
> > --- a/drivers/nor/cfi_flash_amd.c
> > +++ b/drivers/nor/cfi_flash_amd.c
> > @@ -62,8 +62,11 @@ static void amd_read_jedec_ids (struct flash_info *info)
> >  	udelay(1000); /* some flash are slow to respond */
> >
> >  	info->manufacturer_id = jedec_read_mfr(info);
> > -	info->device_id = flash_read_uchar (info,
> > -					FLASH_OFFSET_DEVICE_ID);
> > +	if(info->chipwidth == FLASH_CFI_BY16)
> > +		info->device_id = flash_read16(flash_make_addr(info, 0, FLASH_OFFSET_DEVICE_ID));
> > +	else
> > +		info->device_id = flash_read_uchar (info,
> > +						FLASH_OFFSET_DEVICE_ID);
>
> make this global with all with support
> as don in linux
>
> as this is valid for amd and intel and st
>
Does this mean cp this code to the function
drivers/nor/cfi_flash_intel.c:intel_read_jedec_ids() ?
-- 
Best Regards,
zzs


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox