From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TbQN2-0003Em-J1 for kexec@lists.infradead.org; Thu, 22 Nov 2012 06:34:46 +0000 Date: Thu, 22 Nov 2012 08:34:35 +0200 From: Gleb Natapov Subject: Re: [PATCH v5 1/2] x86/kexec: VMCLEAR vmcss on all cpus if necessary Message-ID: <20121122063435.GA21208@redhat.com> References: <50AC3AA9.7080004@cn.fujitsu.com> <50AC3B10.3090005@cn.fujitsu.com> <20121121103316.GP21208@redhat.com> <50AD78E3.7080901@cn.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <50AD78E3.7080901@cn.fujitsu.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Zhang Yanfei Cc: "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , Marcelo Tosatti T24gVGh1LCBOb3YgMjIsIDIwMTIgYXQgMDg6NTk6MTVBTSArMDgwMCwgWmhhbmcgWWFuZmVpIHdy b3RlOgo+IOS6jiAyMDEy5bm0MTHmnIgyMeaXpSAxODozMywgR2xlYiBOYXRhcG92IOWGmemBkzoK PiA+IE9uIFdlZCwgTm92IDIxLCAyMDEyIGF0IDEwOjIzOjEyQU0gKzA4MDAsIFpoYW5nIFlhbmZl aSB3cm90ZToKPiA+PiBUaGlzIHBhdGNoIGFkZHMgYW4gYXRvbWljIG5vdGlmaWVyIGxpc3QgbmFt ZWQgY3Jhc2hfbm90aWZpZXJfbGlzdC4KPiA+PiBXaGVuIGxvYWRpbmcga3ZtLWludGVsIG1vZHVs ZSwgYSBub3RpZmllciB3aWxsIGJlIHJlZ2lzdGVyZWQgaW4KPiA+PiB0aGUgbGlzdCB0byBlbmFi bGUgdm1jc3MgbG9hZGVkIG9uIGFsbCBjcHVzIHRvIGJlIFZNQ0xFQVInZCBpZgo+ID4+IG5lZWRl ZC4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IFpoYW5nIFlhbmZlaSA8emhhbmd5YW5mZWlAY24u ZnVqaXRzdS5jb20+Cj4gPj4gLS0tCj4gPj4gIGFyY2gveDg2L2luY2x1ZGUvYXNtL2tleGVjLmgg fCAgICAyICsrCj4gPj4gIGFyY2gveDg2L2tlcm5lbC9jcmFzaC5jICAgICAgfCAgIDI1ICsrKysr KysrKysrKysrKysrKysrKysrKysKPiA+PiAgMiBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25z KCspLCAwIGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2luY2x1 ZGUvYXNtL2tleGVjLmggYi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9rZXhlYy5oCj4gPj4gaW5kZXgg MzE3ZmYxNy4uNWUyMmIwMCAxMDA2NDQKPiA+PiAtLS0gYS9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9r ZXhlYy5oCj4gPj4gKysrIGIvYXJjaC94ODYvaW5jbHVkZS9hc20va2V4ZWMuaAo+ID4+IEBAIC0x NjMsNiArMTYzLDggQEAgc3RydWN0IGtpbWFnZV9hcmNoIHsKPiA+PiAgfTsKPiA+PiAgI2VuZGlm Cj4gPj4gIAo+ID4+ICtleHRlcm4gc3RydWN0IGF0b21pY19ub3RpZmllcl9oZWFkIGNyYXNoX25v dGlmaWVyX2xpc3Q7Cj4gPj4gKwo+ID4+ICAjZW5kaWYgLyogX19BU1NFTUJMWV9fICovCj4gPj4g IAo+ID4+ICAjZW5kaWYgLyogX0FTTV9YODZfS0VYRUNfSCAqLwo+ID4+IGRpZmYgLS1naXQgYS9h cmNoL3g4Ni9rZXJuZWwvY3Jhc2guYyBiL2FyY2gveDg2L2tlcm5lbC9jcmFzaC5jCj4gPj4gaW5k ZXggMTNhZDg5OS4uMGYzZDViNCAxMDA2NDQKPiA+PiAtLS0gYS9hcmNoL3g4Ni9rZXJuZWwvY3Jh c2guYwo+ID4+ICsrKyBiL2FyY2gveDg2L2tlcm5lbC9jcmFzaC5jCj4gPj4gQEAgLTE2LDYgKzE2 LDggQEAKPiA+PiAgI2luY2x1ZGUgPGxpbnV4L2RlbGF5Lmg+Cj4gPj4gICNpbmNsdWRlIDxsaW51 eC9lbGYuaD4KPiA+PiAgI2luY2x1ZGUgPGxpbnV4L2VsZmNvcmUuaD4KPiA+PiArI2luY2x1ZGUg PGxpbnV4L21vZHVsZS5oPgo+ID4+ICsjaW5jbHVkZSA8bGludXgvbm90aWZpZXIuaD4KPiA+PiAg Cj4gPj4gICNpbmNsdWRlIDxhc20vcHJvY2Vzc29yLmg+Cj4gPj4gICNpbmNsdWRlIDxhc20vaGFy ZGlycS5oPgo+ID4+IEBAIC0zMCw2ICszMiwxOSBAQAo+ID4+ICAKPiA+PiAgaW50IGluX2NyYXNo X2tleGVjOwo+ID4+ICAKPiA+PiArLyoKPiA+PiArICogVGhlIGxpc3QgaXMgdXNlZCB0byBWTUNM RUFSIHZtY3NzIGxvYWRlZCBvbiBhbGwKPiA+PiArICogY3B1cy4gQW5kIHdoZW4gbG9hZGluZyBr dm1faW50ZWwgbW9kdWxlLCB0aGUKPiA+PiArICogdm1jbGVhciBmdW5jdGlvbiB3aWxsIGJlIHJl Z2lzdGVyZWQgaW4gdGhlIGxpc3QuCj4gPj4gKyAqLwo+ID4+ICtBVE9NSUNfTk9USUZJRVJfSEVB RChjcmFzaF9ub3RpZmllcl9saXN0KTsKPiA+PiArRVhQT1JUX1NZTUJPTF9HUEwoY3Jhc2hfbm90 aWZpZXJfbGlzdCk7Cj4gPj4gKwo+ID4+ICtzdGF0aWMgaW5saW5lIHZvaWQgY3B1X2VtZXJnZW5j eV92bWNsZWFyX2xvYWRlZF92bWNzcyh2b2lkKQo+ID4+ICt7Cj4gPj4gKwlhdG9taWNfbm90aWZp ZXJfY2FsbF9jaGFpbigmY3Jhc2hfbm90aWZpZXJfbGlzdCwgMCwgTlVMTCk7Cj4gPj4gK30KPiA+ PiArCj4gPiBUaGUgbm90aWZpZXIgbGlzdCBpcyBub3QgVk1YIHNwZWNpZmljLiBJdCBtYXkgYmUg dXNlZCBmb3Igb3RoZXIKPiA+IHB1cnBvc2VzLCBzbyBwbGVhc2UgdXNlIGJldHRlciBuYW1lIG9y IGp1c3Qgb3BlbiBjb2RlIGl0Lgo+IAo+IE9LLCB0aGFua3MuIGNyYXNoX25vdGlmaWVyX2xpc3Qg LS0+IHZtY2xlYXJfbm90aWZpZXJfbGlzdD8KSXQgaXMgZXZlbiB3b3JzZS4gWW91IGFyZSBhZGRp bmcgZ2VuZXJhbCBpbmZyYXN0cnVjdHVyZSBoZXJlLCBub3QKcmVsYXRlZCB0byBLVk0gYXQgYWxs LiBDaG9vc2UgbmV1dHJhbCBuYW1lcywgZHJvcCBhbGwgY29tbWVudHMgYWJvdXQKVk1DTEVBUi4K Cj4gdGhlIG5ldyB2NiB2ZXJzaW9uIGhhcyBiZWVuIHNlbnQsIGFueSBjb21tZW50cyBhcmUgd2Vs Y29tZS4KPiAKPiA+IAo+ID4gQUNLcyBmcm9tIGtleGVjIHNpZGUgYXJlIG5lZWRlZC4KPiA+IAo+ ID4+ICAjaWYgZGVmaW5lZChDT05GSUdfU01QKSAmJiBkZWZpbmVkKENPTkZJR19YODZfTE9DQUxf QVBJQykKPiA+PiAgCj4gPj4gIHN0YXRpYyB2b2lkIGtkdW1wX25taV9jYWxsYmFjayhpbnQgY3B1 LCBzdHJ1Y3QgcHRfcmVncyAqcmVncykKPiA+PiBAQCAtNDYsNiArNjEsMTEgQEAgc3RhdGljIHZv aWQga2R1bXBfbm1pX2NhbGxiYWNrKGludCBjcHUsIHN0cnVjdCBwdF9yZWdzICpyZWdzKQo+ID4+ ICAjZW5kaWYKPiA+PiAgCWNyYXNoX3NhdmVfY3B1KHJlZ3MsIGNwdSk7Cj4gPj4gIAo+ID4+ICsJ LyoKPiA+PiArCSAqIFZNQ0xFQVIgdm1jc3MgbG9hZGVkIG9uIGFsbCBjcHVzIGlmIG5lZWRlZC4K PiA+PiArCSAqLwo+ID4+ICsJY3B1X2VtZXJnZW5jeV92bWNsZWFyX2xvYWRlZF92bWNzcygpOwo+ ID4+ICsKPiA+PiAgCS8qIERpc2FibGUgVk1YIG9yIFNWTSBpZiBuZWVkZWQuCj4gPj4gIAkgKgo+ ID4+ICAJICogV2UgbmVlZCB0byBkaXNhYmxlIHZpcnR1YWxpemF0aW9uIG9uIGFsbCBDUFVzLgo+ ID4+IEBAIC04OCw2ICsxMDgsMTEgQEAgdm9pZCBuYXRpdmVfbWFjaGluZV9jcmFzaF9zaHV0ZG93 bihzdHJ1Y3QgcHRfcmVncyAqcmVncykKPiA+PiAgCj4gPj4gIAlrZHVtcF9ubWlfc2hvb3Rkb3du X2NwdXMoKTsKPiA+PiAgCj4gPj4gKwkvKgo+ID4+ICsJICogVk1DTEVBUiB2bWNzcyBsb2FkZWQg b24gdGhpcyBjcHUgaWYgbmVlZGVkLgo+ID4+ICsJICovCj4gPj4gKwljcHVfZW1lcmdlbmN5X3Zt Y2xlYXJfbG9hZGVkX3ZtY3NzKCk7Cj4gPj4gKwo+ID4+ICAJLyogQm9vdGluZyBrZHVtcCBrZXJu ZWwgd2l0aCBWTVggb3IgU1ZNIGVuYWJsZWQgd29uJ3Qgd29yaywKPiA+PiAgCSAqIGJlY2F1c2Ug KGFtb25nIG90aGVyIGxpbWl0YXRpb25zKSB3ZSBjYW4ndCBkaXNhYmxlIHBhZ2luZwo+ID4+ICAJ ICogd2l0aCB0aGUgdmlydCBmbGFncy4KPiA+PiAtLSAKPiA+PiAxLjcuMQo+ID4+Cj4gPj4gLS0K PiA+PiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJz Y3JpYmUgbGludXgta2VybmVsIiBpbgo+ID4+IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv cmRvbW9Admdlci5rZXJuZWwub3JnCj4gPj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDov L3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCj4gPj4gUGxlYXNlIHJlYWQgdGhl IEZBUSBhdCAgaHR0cDovL3d3dy50dXgub3JnL2xrbWwvCj4gPiAKPiA+IC0tCj4gPiAJCQlHbGVi Lgo+ID4gCj4gCgotLQoJCQlHbGViLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18Ka2V4ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH v5 1/2] x86/kexec: VMCLEAR vmcss on all cpus if necessary Date: Thu, 22 Nov 2012 08:34:35 +0200 Message-ID: <20121122063435.GA21208@redhat.com> References: <50AC3AA9.7080004@cn.fujitsu.com> <50AC3B10.3090005@cn.fujitsu.com> <20121121103316.GP21208@redhat.com> <50AD78E3.7080901@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Marcelo Tosatti To: Zhang Yanfei Return-path: Content-Disposition: inline In-Reply-To: <50AD78E3.7080901-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org T24gVGh1LCBOb3YgMjIsIDIwMTIgYXQgMDg6NTk6MTVBTSArMDgwMCwgWmhhbmcgWWFuZmVpIHdy b3RlOgo+IOS6jiAyMDEy5bm0MTHmnIgyMeaXpSAxODozMywgR2xlYiBOYXRhcG92IOWGmemBkzoK PiA+IE9uIFdlZCwgTm92IDIxLCAyMDEyIGF0IDEwOjIzOjEyQU0gKzA4MDAsIFpoYW5nIFlhbmZl aSB3cm90ZToKPiA+PiBUaGlzIHBhdGNoIGFkZHMgYW4gYXRvbWljIG5vdGlmaWVyIGxpc3QgbmFt ZWQgY3Jhc2hfbm90aWZpZXJfbGlzdC4KPiA+PiBXaGVuIGxvYWRpbmcga3ZtLWludGVsIG1vZHVs ZSwgYSBub3RpZmllciB3aWxsIGJlIHJlZ2lzdGVyZWQgaW4KPiA+PiB0aGUgbGlzdCB0byBlbmFi bGUgdm1jc3MgbG9hZGVkIG9uIGFsbCBjcHVzIHRvIGJlIFZNQ0xFQVInZCBpZgo+ID4+IG5lZWRl ZC4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IFpoYW5nIFlhbmZlaSA8emhhbmd5YW5mZWlAY24u ZnVqaXRzdS5jb20+Cj4gPj4gLS0tCj4gPj4gIGFyY2gveDg2L2luY2x1ZGUvYXNtL2tleGVjLmgg fCAgICAyICsrCj4gPj4gIGFyY2gveDg2L2tlcm5lbC9jcmFzaC5jICAgICAgfCAgIDI1ICsrKysr KysrKysrKysrKysrKysrKysrKysKPiA+PiAgMiBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25z KCspLCAwIGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2luY2x1 ZGUvYXNtL2tleGVjLmggYi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9rZXhlYy5oCj4gPj4gaW5kZXgg MzE3ZmYxNy4uNWUyMmIwMCAxMDA2NDQKPiA+PiAtLS0gYS9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9r ZXhlYy5oCj4gPj4gKysrIGIvYXJjaC94ODYvaW5jbHVkZS9hc20va2V4ZWMuaAo+ID4+IEBAIC0x NjMsNiArMTYzLDggQEAgc3RydWN0IGtpbWFnZV9hcmNoIHsKPiA+PiAgfTsKPiA+PiAgI2VuZGlm Cj4gPj4gIAo+ID4+ICtleHRlcm4gc3RydWN0IGF0b21pY19ub3RpZmllcl9oZWFkIGNyYXNoX25v dGlmaWVyX2xpc3Q7Cj4gPj4gKwo+ID4+ICAjZW5kaWYgLyogX19BU1NFTUJMWV9fICovCj4gPj4g IAo+ID4+ICAjZW5kaWYgLyogX0FTTV9YODZfS0VYRUNfSCAqLwo+ID4+IGRpZmYgLS1naXQgYS9h cmNoL3g4Ni9rZXJuZWwvY3Jhc2guYyBiL2FyY2gveDg2L2tlcm5lbC9jcmFzaC5jCj4gPj4gaW5k ZXggMTNhZDg5OS4uMGYzZDViNCAxMDA2NDQKPiA+PiAtLS0gYS9hcmNoL3g4Ni9rZXJuZWwvY3Jh c2guYwo+ID4+ICsrKyBiL2FyY2gveDg2L2tlcm5lbC9jcmFzaC5jCj4gPj4gQEAgLTE2LDYgKzE2 LDggQEAKPiA+PiAgI2luY2x1ZGUgPGxpbnV4L2RlbGF5Lmg+Cj4gPj4gICNpbmNsdWRlIDxsaW51 eC9lbGYuaD4KPiA+PiAgI2luY2x1ZGUgPGxpbnV4L2VsZmNvcmUuaD4KPiA+PiArI2luY2x1ZGUg PGxpbnV4L21vZHVsZS5oPgo+ID4+ICsjaW5jbHVkZSA8bGludXgvbm90aWZpZXIuaD4KPiA+PiAg Cj4gPj4gICNpbmNsdWRlIDxhc20vcHJvY2Vzc29yLmg+Cj4gPj4gICNpbmNsdWRlIDxhc20vaGFy ZGlycS5oPgo+ID4+IEBAIC0zMCw2ICszMiwxOSBAQAo+ID4+ICAKPiA+PiAgaW50IGluX2NyYXNo X2tleGVjOwo+ID4+ICAKPiA+PiArLyoKPiA+PiArICogVGhlIGxpc3QgaXMgdXNlZCB0byBWTUNM RUFSIHZtY3NzIGxvYWRlZCBvbiBhbGwKPiA+PiArICogY3B1cy4gQW5kIHdoZW4gbG9hZGluZyBr dm1faW50ZWwgbW9kdWxlLCB0aGUKPiA+PiArICogdm1jbGVhciBmdW5jdGlvbiB3aWxsIGJlIHJl Z2lzdGVyZWQgaW4gdGhlIGxpc3QuCj4gPj4gKyAqLwo+ID4+ICtBVE9NSUNfTk9USUZJRVJfSEVB RChjcmFzaF9ub3RpZmllcl9saXN0KTsKPiA+PiArRVhQT1JUX1NZTUJPTF9HUEwoY3Jhc2hfbm90 aWZpZXJfbGlzdCk7Cj4gPj4gKwo+ID4+ICtzdGF0aWMgaW5saW5lIHZvaWQgY3B1X2VtZXJnZW5j eV92bWNsZWFyX2xvYWRlZF92bWNzcyh2b2lkKQo+ID4+ICt7Cj4gPj4gKwlhdG9taWNfbm90aWZp ZXJfY2FsbF9jaGFpbigmY3Jhc2hfbm90aWZpZXJfbGlzdCwgMCwgTlVMTCk7Cj4gPj4gK30KPiA+ PiArCj4gPiBUaGUgbm90aWZpZXIgbGlzdCBpcyBub3QgVk1YIHNwZWNpZmljLiBJdCBtYXkgYmUg dXNlZCBmb3Igb3RoZXIKPiA+IHB1cnBvc2VzLCBzbyBwbGVhc2UgdXNlIGJldHRlciBuYW1lIG9y IGp1c3Qgb3BlbiBjb2RlIGl0Lgo+IAo+IE9LLCB0aGFua3MuIGNyYXNoX25vdGlmaWVyX2xpc3Qg LS0+IHZtY2xlYXJfbm90aWZpZXJfbGlzdD8KSXQgaXMgZXZlbiB3b3JzZS4gWW91IGFyZSBhZGRp bmcgZ2VuZXJhbCBpbmZyYXN0cnVjdHVyZSBoZXJlLCBub3QKcmVsYXRlZCB0byBLVk0gYXQgYWxs LiBDaG9vc2UgbmV1dHJhbCBuYW1lcywgZHJvcCBhbGwgY29tbWVudHMgYWJvdXQKVk1DTEVBUi4K Cj4gdGhlIG5ldyB2NiB2ZXJzaW9uIGhhcyBiZWVuIHNlbnQsIGFueSBjb21tZW50cyBhcmUgd2Vs Y29tZS4KPiAKPiA+IAo+ID4gQUNLcyBmcm9tIGtleGVjIHNpZGUgYXJlIG5lZWRlZC4KPiA+IAo+ ID4+ICAjaWYgZGVmaW5lZChDT05GSUdfU01QKSAmJiBkZWZpbmVkKENPTkZJR19YODZfTE9DQUxf QVBJQykKPiA+PiAgCj4gPj4gIHN0YXRpYyB2b2lkIGtkdW1wX25taV9jYWxsYmFjayhpbnQgY3B1 LCBzdHJ1Y3QgcHRfcmVncyAqcmVncykKPiA+PiBAQCAtNDYsNiArNjEsMTEgQEAgc3RhdGljIHZv aWQga2R1bXBfbm1pX2NhbGxiYWNrKGludCBjcHUsIHN0cnVjdCBwdF9yZWdzICpyZWdzKQo+ID4+ ICAjZW5kaWYKPiA+PiAgCWNyYXNoX3NhdmVfY3B1KHJlZ3MsIGNwdSk7Cj4gPj4gIAo+ID4+ICsJ LyoKPiA+PiArCSAqIFZNQ0xFQVIgdm1jc3MgbG9hZGVkIG9uIGFsbCBjcHVzIGlmIG5lZWRlZC4K PiA+PiArCSAqLwo+ID4+ICsJY3B1X2VtZXJnZW5jeV92bWNsZWFyX2xvYWRlZF92bWNzcygpOwo+ ID4+ICsKPiA+PiAgCS8qIERpc2FibGUgVk1YIG9yIFNWTSBpZiBuZWVkZWQuCj4gPj4gIAkgKgo+ ID4+ICAJICogV2UgbmVlZCB0byBkaXNhYmxlIHZpcnR1YWxpemF0aW9uIG9uIGFsbCBDUFVzLgo+ ID4+IEBAIC04OCw2ICsxMDgsMTEgQEAgdm9pZCBuYXRpdmVfbWFjaGluZV9jcmFzaF9zaHV0ZG93 bihzdHJ1Y3QgcHRfcmVncyAqcmVncykKPiA+PiAgCj4gPj4gIAlrZHVtcF9ubWlfc2hvb3Rkb3du X2NwdXMoKTsKPiA+PiAgCj4gPj4gKwkvKgo+ID4+ICsJICogVk1DTEVBUiB2bWNzcyBsb2FkZWQg b24gdGhpcyBjcHUgaWYgbmVlZGVkLgo+ID4+ICsJICovCj4gPj4gKwljcHVfZW1lcmdlbmN5X3Zt Y2xlYXJfbG9hZGVkX3ZtY3NzKCk7Cj4gPj4gKwo+ID4+ICAJLyogQm9vdGluZyBrZHVtcCBrZXJu ZWwgd2l0aCBWTVggb3IgU1ZNIGVuYWJsZWQgd29uJ3Qgd29yaywKPiA+PiAgCSAqIGJlY2F1c2Ug KGFtb25nIG90aGVyIGxpbWl0YXRpb25zKSB3ZSBjYW4ndCBkaXNhYmxlIHBhZ2luZwo+ID4+ICAJ ICogd2l0aCB0aGUgdmlydCBmbGFncy4KPiA+PiAtLSAKPiA+PiAxLjcuMQo+ID4+Cj4gPj4gLS0K PiA+PiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJz Y3JpYmUgbGludXgta2VybmVsIiBpbgo+ID4+IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv cmRvbW9Admdlci5rZXJuZWwub3JnCj4gPj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDov L3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCj4gPj4gUGxlYXNlIHJlYWQgdGhl IEZBUSBhdCAgaHR0cDovL3d3dy50dXgub3JnL2xrbWwvCj4gPiAKPiA+IC0tCj4gPiAJCQlHbGVi Lgo+ID4gCj4gCgotLQoJCQlHbGViLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18Ka2V4ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755505Ab2KVTbw (ORCPT ); Thu, 22 Nov 2012 14:31:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12257 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753120Ab2KVTbs convert rfc822-to-8bit (ORCPT ); Thu, 22 Nov 2012 14:31:48 -0500 Date: Thu, 22 Nov 2012 08:34:35 +0200 From: Gleb Natapov To: Zhang Yanfei Cc: "x86@kernel.org" , "kexec@lists.infradead.org" , Marcelo Tosatti , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" Subject: Re: [PATCH v5 1/2] x86/kexec: VMCLEAR vmcss on all cpus if necessary Message-ID: <20121122063435.GA21208@redhat.com> References: <50AC3AA9.7080004@cn.fujitsu.com> <50AC3B10.3090005@cn.fujitsu.com> <20121121103316.GP21208@redhat.com> <50AD78E3.7080901@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <50AD78E3.7080901@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 22, 2012 at 08:59:15AM +0800, Zhang Yanfei wrote: > 于 2012年11月21日 18:33, Gleb Natapov 写道: > > On Wed, Nov 21, 2012 at 10:23:12AM +0800, Zhang Yanfei wrote: > >> This patch adds an atomic notifier list named crash_notifier_list. > >> When loading kvm-intel module, a notifier will be registered in > >> the list to enable vmcss loaded on all cpus to be VMCLEAR'd if > >> needed. > >> > >> Signed-off-by: Zhang Yanfei > >> --- > >> arch/x86/include/asm/kexec.h | 2 ++ > >> arch/x86/kernel/crash.c | 25 +++++++++++++++++++++++++ > >> 2 files changed, 27 insertions(+), 0 deletions(-) > >> > >> diff --git a/arch/x86/include/asm/kexec.h b/arch/x86/include/asm/kexec.h > >> index 317ff17..5e22b00 100644 > >> --- a/arch/x86/include/asm/kexec.h > >> +++ b/arch/x86/include/asm/kexec.h > >> @@ -163,6 +163,8 @@ struct kimage_arch { > >> }; > >> #endif > >> > >> +extern struct atomic_notifier_head crash_notifier_list; > >> + > >> #endif /* __ASSEMBLY__ */ > >> > >> #endif /* _ASM_X86_KEXEC_H */ > >> diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c > >> index 13ad899..0f3d5b4 100644 > >> --- a/arch/x86/kernel/crash.c > >> +++ b/arch/x86/kernel/crash.c > >> @@ -16,6 +16,8 @@ > >> #include > >> #include > >> #include > >> +#include > >> +#include > >> > >> #include > >> #include > >> @@ -30,6 +32,19 @@ > >> > >> int in_crash_kexec; > >> > >> +/* > >> + * The list is used to VMCLEAR vmcss loaded on all > >> + * cpus. And when loading kvm_intel module, the > >> + * vmclear function will be registered in the list. > >> + */ > >> +ATOMIC_NOTIFIER_HEAD(crash_notifier_list); > >> +EXPORT_SYMBOL_GPL(crash_notifier_list); > >> + > >> +static inline void cpu_emergency_vmclear_loaded_vmcss(void) > >> +{ > >> + atomic_notifier_call_chain(&crash_notifier_list, 0, NULL); > >> +} > >> + > > The notifier list is not VMX specific. It may be used for other > > purposes, so please use better name or just open code it. > > OK, thanks. crash_notifier_list --> vmclear_notifier_list? It is even worse. You are adding general infrastructure here, not related to KVM at all. Choose neutral names, drop all comments about VMCLEAR. > the new v6 version has been sent, any comments are welcome. > > > > > ACKs from kexec side are needed. > > > >> #if defined(CONFIG_SMP) && defined(CONFIG_X86_LOCAL_APIC) > >> > >> static void kdump_nmi_callback(int cpu, struct pt_regs *regs) > >> @@ -46,6 +61,11 @@ static void kdump_nmi_callback(int cpu, struct pt_regs *regs) > >> #endif > >> crash_save_cpu(regs, cpu); > >> > >> + /* > >> + * VMCLEAR vmcss loaded on all cpus if needed. > >> + */ > >> + cpu_emergency_vmclear_loaded_vmcss(); > >> + > >> /* Disable VMX or SVM if needed. > >> * > >> * We need to disable virtualization on all CPUs. > >> @@ -88,6 +108,11 @@ void native_machine_crash_shutdown(struct pt_regs *regs) > >> > >> kdump_nmi_shootdown_cpus(); > >> > >> + /* > >> + * VMCLEAR vmcss loaded on this cpu if needed. > >> + */ > >> + cpu_emergency_vmclear_loaded_vmcss(); > >> + > >> /* Booting kdump kernel with VMX or SVM enabled won't work, > >> * because (among other limitations) we can't disable paging > >> * with the virt flags. > >> -- > >> 1.7.1 > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> Please read the FAQ at http://www.tux.org/lkml/ > > > > -- > > Gleb. > > > -- Gleb.