Re: [PATCH] drm/i915: set the AVI VIC of the HDMI mode

[Thierry Reding <thierry.reding@avionic-design.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1547 bytes --]

On Thu, Nov 22, 2012 at 09:00:24AM +0100, Rafał Miłecki wrote:
> 2012/11/22 Thierry Reding <thierry.reding@avionic-design.de>:
> > On Wed, Nov 21, 2012 at 05:08:12PM +0100, Daniel Vetter wrote:
> >> On Wed, Nov 21, 2012 at 4:47 PM, Thierry Reding
> >> <thierry.reding@avionic-design.de> wrote:
> >> > Oh great, so I copied that table for nothing. Thanks for Cc'ing, I can
> >> > reuse that in the HDMI infoframe series.
> >>
> >> Wrt the infoframe series, I think it'd be awesome if you could convert
> >> i915 and radeon (iirc the existing drivers with the "best" avi
> >> infoframe support) over to the new code. This gives some nice
> >> validation, both by testing on actual hw and that the interface is
> >> sane, since it'll be used by 2-3 different drivers then.
> >
> > I'll have to rely on somebody else to do the testing since I don't have
> > an HDMI capable hardware except Tegra to run this on. But yes, I had
> > planned to convert Tegra and at least one other driver for reference.
> > But I guess while at it I could just as well convert all of them.
> 
> I'll take a look at radeon (I'll try to convert it to the new
> functions) over weekend.

Okay, great! I think for radeon things should be the easiest since it
doesn't currently fill in anything but the colorspace field. Judging by
the bug report that Paulo mentioned this will probably not be enough for
some hardware, but should be enough according to the specification.
Having more data in the AVI infoframe shouldn't hurt, though.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx