From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines Date: Thu, 22 Nov 2012 10:27:10 +0000 Message-ID: <20121122102710.GD4328@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Viresh Kumar Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org T24gVGh1LCAyMiBOb3YgMjAxMiwgVmlyZXNoIEt1bWFyIHdyb3RlOgoKPiBUaGlzIHBhdGNoIGZy ZWVzIHN0bXBlIGRyaXZlciBmcm9tIHRlbnNpb24gb2YgZnJlZWluZyByZXNvdXJjZXMgOikKPiBk ZXZtXyogZGVyaXZhdGl2ZXMgb2YgbXVsdGlwbGUgcm91dGluZXMgYXJlIHVzZWQgd2hpbGUgYWxs b2NhdGluZyByZXNvdXJjZXMsCj4gd2hpY2ggd291bGQgYmUgZnJlZWQgYXV0b21hdGljYWxseSBi eSBrZXJuZWwuCj4gCj4gU2lnbmVkLW9mZi1ieTogVmlyZXNoIEt1bWFyIDx2aXJlc2gua3VtYXJA bGluYXJvLm9yZz4KPiAtLS0KPiAKPiBWMS0+VjI6Cj4gLS0tLS0tCj4gLSBSZWJhc2VkIG92ZXIg bGF0ZXN0IGZvci1uZXh0IGZyb20gU2FtdWVsCj4gLSB1cGRhdGVkIGFkZGl0aW9uYWwga3phbGxv YyB3aXRoIGRldm1fa3phbGxvYygpLCBmaXJzdCBvbmUgc2VlbiBiZWxvdy4KPiAKPiAgZHJpdmVy cy9tZmQvc3RtcGUuYyB8IDYwICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAzOSBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvc3RtcGUuYyBiL2RyaXZl cnMvbWZkL3N0bXBlLmMKPiBpbmRleCBiYTE1N2Q0Li5jMGRmNGI5IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvbWZkL3N0bXBlLmMKPiArKysgYi9kcml2ZXJzL21mZC9zdG1wZS5jCj4gQEAgLTEwNTIs MTcgKzEwNTIsMTcgQEAgaW50IF9fZGV2aW5pdCBzdG1wZV9wcm9iZShzdHJ1Y3Qgc3RtcGVfY2xp ZW50X2luZm8gKmNpLCBpbnQgcGFydG51bSkKPiAgCWludCByZXQ7Cj4gIAo+ICAJaWYgKCFwZGF0 YSkgewo+IC0JCWlmIChucCkgewo+IC0JCQlwZGF0YSA9IGt6YWxsb2Moc2l6ZW9mKCpwZGF0YSks IEdGUF9LRVJORUwpOwo+IC0JCQlpZiAoIXBkYXRhKQo+IC0JCQkJcmV0dXJuIC1FTk9NRU07Cj4g LQo+IC0JCQlzdG1wZV9vZl9wcm9iZShwZGF0YSwgbnApOwo+IC0JCX0gZWxzZQo+ICsJCWlmICgh bnApCgpJJ20gYXNzdW1pbmcgeW91J3ZlIHJldmVyc2VkIHRoZSBzZW1hbnRpY3MgaGVyZSBmb3Ig PjgwIGNoYXJzIHJlYXNvbnM/CgpJIHNlZSBubyBoYXJtIGluIGl0IHRob3VnaC4KCkFja2VkLWJ5 OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgoKLS0gCkxlZSBKb25lcwpMaW5hcm8g U1QtRXJpY3Nzb24gTGFuZGluZyBUZWFtIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ug c29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8 IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2 aWNldHJlZS1kaXNjdXNzIG1haWxpbmcgbGlzdApkZXZpY2V0cmVlLWRpc2N1c3NAbGlzdHMub3ps YWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8vZGV2aWNldHJlZS1kaXNj dXNzCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756248Ab2KVTDY (ORCPT ); Thu, 22 Nov 2012 14:03:24 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:62370 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755482Ab2KVTDV (ORCPT ); Thu, 22 Nov 2012 14:03:21 -0500 Date: Thu, 22 Nov 2012 10:27:10 +0000 From: Lee Jones To: Viresh Kumar Cc: sameo@linux.intel.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com Subject: Re: [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines Message-ID: <20121122102710.GD4328@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Nov 2012, Viresh Kumar wrote: > This patch frees stmpe driver from tension of freeing resources :) > devm_* derivatives of multiple routines are used while allocating resources, > which would be freed automatically by kernel. > > Signed-off-by: Viresh Kumar > --- > > V1->V2: > ------ > - Rebased over latest for-next from Samuel > - updated additional kzalloc with devm_kzalloc(), first one seen below. > > drivers/mfd/stmpe.c | 60 +++++++++++++++++++---------------------------------- > 1 file changed, 21 insertions(+), 39 deletions(-) > > diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c > index ba157d4..c0df4b9 100644 > --- a/drivers/mfd/stmpe.c > +++ b/drivers/mfd/stmpe.c > @@ -1052,17 +1052,17 @@ int __devinit stmpe_probe(struct stmpe_client_info *ci, int partnum) > int ret; > > if (!pdata) { > - if (np) { > - pdata = kzalloc(sizeof(*pdata), GFP_KERNEL); > - if (!pdata) > - return -ENOMEM; > - > - stmpe_of_probe(pdata, np); > - } else > + if (!np) I'm assuming you've reversed the semantics here for >80 chars reasons? I see no harm in it though. Acked-by: Lee Jones -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog