All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Bauer <olafbauer@freenet.de>
To: linux-media@vger.kernel.org
Subject: [PATCH] bttv: Filter debugging messages
Date: Thu, 22 Nov 2012 12:26:31 +0100	[thread overview]
Message-ID: <20121122122631.78340fc7@freenet.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

My logfiles and dmesg output have become almost unreadable due to
repeated, almost empty lines.

[ 3606.212316] >
[ 3606.212738] >
...
[ 3627.177280] >
[ 3627.177775] >
...

They start one hour after vdr daemon is launched. Each section contains
13 lines and is repeated every 21 seconds. Kernel driver for my
AverMedia DVB-T 771 is bttv, kernel is 3.6.6-1-ARCH (Arch Linux). I
installed v4l-dvb from git and get the same result but with one line
appended to each section

[ 3688.860166] >
[ 3688.860570] >
[ 3691.188200] dvb_frontend_poll: 8 callbacks suppressed

The attached patch suppresses at least the useless ">" output.


[-- Attachment #2: bttv-i2c.patch --]
[-- Type: text/x-patch, Size: 437 bytes --]

diff -ur a/drivers/media/pci/bt8xx/bttv-i2c.c b/drivers/media/pci/bt8xx/bttv-i2c.c
--- a/drivers/media/pci/bt8xx/bttv-i2c.c	2012-11-22 09:56:25.817307254 +0100
+++ b/drivers/media/pci/bt8xx/bttv-i2c.c	2012-11-22 10:01:46.014371997 +0100
@@ -174,7 +174,7 @@
 		if (i2c_debug)
 			pr_cont(" %02x", msg->buf[cnt]);
 	}
-	if (!(xmit & BT878_I2C_NOSTOP))
+	if (i2c_debug && !(xmit & BT878_I2C_NOSTOP))
 		pr_cont(">\n");
 	return msg->len;
 

                 reply	other threads:[~2012-11-22 18:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121122122631.78340fc7@freenet.de \
    --to=olafbauer@freenet.de \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.