From: Greg KH <gregkh@linuxfoundation.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: arnd@arndb.de,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Suggestion] drivers/char: in hpet.c, check for hdp->hd_nirqs
Date: Thu, 22 Nov 2012 10:24:51 -0800 [thread overview]
Message-ID: <20121122182451.GD25392@kroah.com> (raw)
In-Reply-To: <50ADAF18.7090404@asianux.com>
On Thu, Nov 22, 2012 at 12:50:32PM +0800, Chen Gang wrote:
> Hello Arnd Bergmann, Greg Kroah-Hartman
>
> in drivers/char/hpet.c:1009
> I suggest to add check for hdp->hd_nirqs whether equal or larger than 32 (HPET_MAX_TIMERS)
> the type of irqp->interrupt_count is u8 (include/acpi/acrestyp.h:349)
> the type of hdp->hd_irq is "unsigned int hd_irq[HPET_MAX_TIMERS]" (include/linux/hpet.h:99)
> #define HPET_MAX_TIMERS (32) (include/linux/hpet.h:38)
>
> additional information:
> acpi_register_gsi() not check the boundaries of how many irqs (at least, unlimited for u8).
> maybe (only maybe) the irqp->interrupt_count is always less than 32 by hardware limitation.
> I do not know whether it is a bug, so as a suggestion.
Care to send a patch that implements this?
thanks,
greg k-h
next prev parent reply other threads:[~2012-11-22 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 4:50 [Suggestion] drivers/char: in hpet.c, check for hdp->hd_nirqs Chen Gang
2012-11-22 18:24 ` Greg KH [this message]
2012-11-23 1:12 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121122182451.GD25392@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.