All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Mark Tinguely <tinguely@sgi.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: fix the buffer log format for contiguous buffers
Date: Fri, 23 Nov 2012 02:37:09 -0500	[thread overview]
Message-ID: <20121123073708.GA5159@infradead.org> (raw)
In-Reply-To: <20121123014714.GB32450@dastard>

On Fri, Nov 23, 2012 at 12:47:14PM +1100, Dave Chinner wrote:
> This debug code is a lot more broken than just this. It's completely
> unaware of discontiguous buffers....
> 
> I'm wondering if we should just remove the XFS_TRANS_DEBUG code
> because it doesn't ever get used....

As far as I know it has been unused since I started working on XFS,
so removing it sounds fine to me.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-11-23  7:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-20 22:41 [PATCH 0/2] discontiguous buffer patches Mark Tinguely
2012-11-20 22:41 ` [PATCH 1/2] xfs: use b_maps[] for discontiguous buffers Mark Tinguely
2012-11-21  9:51   ` Christoph Hellwig
2012-11-23  1:32   ` Dave Chinner
2012-11-20 22:41 ` [PATCH 2/2] xfs: fix the buffer log format for contiguous buffers Mark Tinguely
2012-11-21  9:54   ` Christoph Hellwig
2012-11-21 13:21     ` Mark Tinguely
2012-11-23  1:47   ` Dave Chinner
2012-11-23  7:37     ` Christoph Hellwig [this message]
2012-11-25 18:59     ` Mark Tinguely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121123073708.GA5159@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=tinguely@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.