From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: alsa-devel@alsa-project.org, Shawn Guo <shawn.guo@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [BUGFIX PATCH] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm
Date: Fri, 23 Nov 2012 17:13:09 +0900 [thread overview]
Message-ID: <20121123081307.GA4529@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20655.7916.566188.590202@ipc1.ka-ro>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On Fri, Nov 23, 2012 at 07:59:56AM +0100, Lothar Waßmann wrote:
> Mark Brown writes:
> > What is the actual bug here? This fix doesn't look obviously right, and
> > if we do need to move to -objs for some reason then the block ought to
> > be in the -objs section of the Makefile.
> As I mentioned in the part of my email that you didn't quote, if the
> sound driver is being compiled as module, the files imx-pcm-fiq.c or
> imx-pcm-dma.c which should be compiled as part of imx-pcm.o will not
> be touched by the compiler:
That's more detailed than your previous mail but you're still only
describing the symptom, not the what the actual error is or how it's
fixed...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-23 8:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 12:31 [BUGFIX PATCH] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm Lothar Waßmann
2012-11-22 12:31 ` Lothar Waßmann
2012-11-22 12:31 ` [PATCH] ASoC: imx: add MODULE_LICENSE("GPL") Lothar Waßmann
2012-11-22 12:31 ` Lothar Waßmann
2012-11-23 14:40 ` Mark Brown
2012-11-22 12:31 ` [BUGFIX PATCH] ASoC: imx-sgtl5000: prevent module from being unloaded when in use Lothar Waßmann
2012-11-22 12:31 ` Lothar Waßmann
2012-11-23 14:42 ` Mark Brown
2012-11-22 12:31 ` [PATCH] ASoC: mxs-saif: export mxs_saif_put_mclk,mxs_saif_get_mclk Lothar Waßmann
2012-11-22 12:31 ` Lothar Waßmann
2012-11-23 2:06 ` Mark Brown
2012-11-23 7:21 ` Lothar Waßmann
2012-11-23 14:45 ` Mark Brown
2012-11-26 8:49 ` Lothar Waßmann
2012-11-22 12:31 ` [PATCH] ASoC: dmaengine_pcm: set MODULE_LICENSE Lothar Waßmann
2012-11-22 12:31 ` Lothar Waßmann
2012-11-23 2:05 ` [BUGFIX PATCH] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm Mark Brown
2012-11-23 6:59 ` Lothar Waßmann
2012-11-23 8:13 ` Mark Brown [this message]
2012-11-23 9:12 ` [PATCH v2] " Lothar Waßmann
2012-11-23 9:12 ` Lothar Waßmann
2012-11-23 10:08 ` Mark Brown
2012-11-23 10:21 ` Lothar Waßmann
2012-11-23 11:47 ` Mark Brown
2012-11-26 8:50 ` [PATCH v3] " Lothar Waßmann
2012-11-27 19:36 ` [PATCH v2] " Mark Brown
2012-11-27 19:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123081307.GA4529@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=LW@KARO-electronics.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.