From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: Dave Chinner <dchinner@redhat.com>
Cc: Ben Myers <bpm@sgi.com>, stable@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix broken error handling in xfs_vm_writepage
Date: Fri, 23 Nov 2012 08:44:22 +0100 [thread overview]
Message-ID: <201211230844.22438.PeterHuewe@gmx.de> (raw)
In-Reply-To: <20121123010123.GD18889@devil.redhat.com>
Hi Dave,
Am Freitag, 23. November 2012, 02:01:23 schrieb Dave Chinner:
> Any particular reason you picked this patch for a backport and not
> many of the other fixes that went into the 3.7 series?
Mainly two reasons:
time and before spending many hours trying to 'backport' all this stuff, I first
wanted to see what the response would be like in general.
I'm still new to the stable kernel business, so I already expected that there
will be some learning curve ;)
Maybe I should add a "Learners Sticker" to my first xx stable related messages
:P
So I really appreciate your feedback.
>
> As it is, this problem is not that easy to hit, and I'm wary of
> backporting changes to the io completion/Io submission error
> handling paths to stable kernels without wider testing of the fix
> (i.e. release of 3.7 and then a couple of weeks of people using it).
> That's the reason why I didn't put a cc to the stable kernel on the
> commit in the first place.
>
> Sometimes there's good reason for being cautious about
> backporting fixes to stable kernels - if the problem is not being
> reported by users then letting the fixes get out into the real world
> for a while before backporting them to the stable kernels is the
> right approach. Stable kernels are supposed to be stable, and as
> such we want to be certain that changes are not going to have
> unintneded consequences and then have to rush more fixes back to the
> stable kernels because we broke them....
As stated in the other mail, I was a bit too eager here as well ;)
We should probably wait with the inclusion - so sorry for the noise.
Thanks,
PeterH
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-23 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1353625410-1413-1-git-send-email-peterhuewe@gmx.de>
2012-11-23 1:01 ` [PATCH] xfs: fix broken error handling in xfs_vm_writepage Dave Chinner
2012-11-23 7:44 ` Peter Hüwe [this message]
2012-11-12 0:49 Dave Chinner
2012-11-12 0:58 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211230844.22438.PeterHuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=bpm@sgi.com \
--cc=dchinner@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.