From: Johan Hedberg <johan.hedberg@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC v0 00/11] External HFP Profile
Date: Fri, 23 Nov 2012 10:54:32 +0200 [thread overview]
Message-ID: <20121123085432.GA4850@x220> (raw)
In-Reply-To: <20121123084420.GA4271@x220>
[-- Attachment #1: Type: text/plain, Size: 3051 bytes --]
Hi Claudio,
On Fri, Nov 23, 2012, Johan Hedberg wrote:
> On Thu, Nov 22, 2012, Claudio Takahasi wrote:
> > BlueZ supports now external profile registration, see:
> > bluez/doc/profile-api.txt
> >
> > This patch series has the initial implementation of the HFP external
> > profile in oFono. HandsfreeAgent and HandsfreeGateway interfaces were
> > removed from BlueZ.
> >
> > The next step: implement SCO connection handling in oFono.
>
> In general the patches seem quite good, but I get the following when
> connecting HFP, disconnecting and reconnecting (all actions triggered
> from the phone side):
>
> ofonod[3940]: plugins/hfp_hf.c:profile_new_connection() Profile handler NewConnection
> ofonod[3940]: plugins/hfp_hf.c:profile_new_connection() hfp_data: 0x4e190f0 SLC FD: 9 Version: 0x0106 Features: 0x0027
> ==3940== Invalid read of size 8
> ==3940== at 0x47E565: profile_new_connection (hfp_hf.c:196)
> ==3940== by 0x40F960: process_message.isra.0 (object.c:197)
> ==3940== by 0x37F181D874: ??? (in /usr/lib64/libdbus-1.so.3.7.1)
> ==3940== by 0x37F180FAEF: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.7.1)
> ==3940== by 0x40DFE7: message_dispatch (mainloop.c:76)
> ==3940== by 0x37EE0483BA: g_timeout_dispatch (gmain.c:3882)
> ==3940== by 0x37EE047824: g_main_context_dispatch (gmain.c:2539)
> ==3940== by 0x37EE047B57: g_main_context_iterate.isra.23 (gmain.c:3146)
> ==3940== by 0x37EE047F51: g_main_loop_run (gmain.c:3340)
> ==3940== by 0x40DC41: main (main.c:247)
> ==3940== Address 0x4e19130 is 64 bytes inside a block of size 96 free'd
> ==3940== at 0x4A07786: free (vg_replace_malloc.c:446)
> ==3940== by 0x37EE04D50E: g_free (gmem.c:252)
> ==3940== by 0x37EE045797: g_source_callback_unref (gmain.c:1288)
> ==3940== by 0x37EE04528A: g_source_destroy_internal (gmain.c:957)
> ==3940== by 0x37EE04786F: g_main_context_dispatch (gmain.c:2563)
> ==3940== by 0x37EE047B57: g_main_context_iterate.isra.23 (gmain.c:3146)
> ==3940== by 0x37EE047F51: g_main_loop_run (gmain.c:3340)
> ==3940== by 0x40DC41: main (main.c:247)
I also found this leak:
==3940== 195 (96 direct, 99 indirect) bytes in 1 blocks are definitely lost in loss record 134 of 175
==3940== at 0x4A0881C: malloc (vg_replace_malloc.c:270)
==3940== by 0x37EE04D55D: g_try_malloc0 (gmem.c:296)
==3940== by 0x47E2F3: hfp_hf_probe (hfp_hf.c:225)
==3940== by 0x47B9A4: device_properties_cb (bluetooth.c:307)
==3940== by 0x37F180C729: ??? (in /usr/lib64/libdbus-1.so.3.7.1)
==3940== by 0x37F180F7F2: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.7.1)
==3940== by 0x40DFE7: message_dispatch (mainloop.c:76)
==3940== by 0x37EE0483BA: g_timeout_dispatch (gmain.c:3882)
==3940== by 0x37EE047824: g_main_context_dispatch (gmain.c:2539)
==3940== by 0x37EE047B57: g_main_context_iterate.isra.23 (gmain.c:3146)
==3940== by 0x37EE047F51: g_main_loop_run (gmain.c:3340)
==3940== by 0x40DC41: main (main.c:247)
Johan
next prev parent reply other threads:[~2012-11-23 8:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 17:53 [RFC v0 00/11] External HFP Profile Claudio Takahasi
2012-11-22 17:53 ` [RFC v0 01/11] hfp_hf: Add HFP external Profile registration Claudio Takahasi
2012-11-26 11:08 ` Johan Hedberg
2012-11-26 11:24 ` Johan Hedberg
2012-11-22 17:53 ` [RFC v0 02/11] hfp_hf: Add BlueZ Profile handler Claudio Takahasi
2012-11-22 17:53 ` [RFC v0 03/11] hfp_hf: Add parsing of Profile NewConnection call Claudio Takahasi
2012-11-22 17:53 ` [RFC v0 04/11] hfp_hf: Add SLC setup Claudio Takahasi
2012-11-22 17:53 ` [RFC v0 05/11] hfp_hf: Add Profile1 Release Claudio Takahasi
2012-11-22 17:53 ` [RFC v0 06/11] hfp_hf: Remove HandsfreeAgent and HandsfreeGateway Claudio Takahasi
2012-11-22 17:53 ` [RFC v0 07/11] hfp_hf: Register HFP modem dynamically Claudio Takahasi
2012-11-22 17:53 ` [RFC v0 08/11] hfp_hf: Fix updating alias Claudio Takahasi
2012-11-22 17:53 ` [RFC v0 09/11] bluetooth: Reuse D-Bus dictionary parser function Claudio Takahasi
2012-11-22 17:53 ` [RFC v0 10/11] hfp_hf: Add Version and Features parsing Claudio Takahasi
2012-11-22 17:53 ` [RFC v0 11/11] bluetooth: Use generic function to parse dict Claudio Takahasi
2012-11-23 8:44 ` [RFC v0 00/11] External HFP Profile Johan Hedberg
2012-11-23 8:54 ` Johan Hedberg [this message]
2012-11-23 11:43 ` Johan Hedberg
2012-11-26 13:26 ` [RFC v1 00/15] " Claudio Takahasi
2012-11-26 13:26 ` [RFC v1 01/15] hfp_hf: Add HFP external Profile registration Claudio Takahasi
2012-11-26 13:26 ` [RFC v1 02/15] hfp_hf: Add BlueZ Profile handler Claudio Takahasi
2012-11-26 13:26 ` [RFC v1 03/15] hfp_hf: Add parsing of Profile NewConnection call Claudio Takahasi
2012-11-26 13:26 ` [RFC v1 04/15] hfp_hf: Add SLC setup Claudio Takahasi
2012-11-26 13:26 ` [RFC v1 05/15] hfp_hf: Add Profile1 Release Claudio Takahasi
2012-11-26 13:27 ` [RFC v1 06/15] hfp_hf: Remove HandsfreeAgent and HandsfreeGateway Claudio Takahasi
2012-11-26 13:27 ` [RFC v1 07/15] hfp_hf: Register HFP modem dynamically Claudio Takahasi
2012-11-26 13:27 ` [RFC v1 08/15] hfp_hf: Fix updating alias Claudio Takahasi
2012-11-26 13:27 ` [RFC v1 09/15] bluetooth: Reuse D-Bus dictionary parser function Claudio Takahasi
2012-11-26 13:27 ` [RFC v1 10/15] hfp_hf: Add Version and Features parsing Claudio Takahasi
2012-11-26 13:27 ` [RFC v1 11/15] bluetooth: Use generic function to parse dict Claudio Takahasi
2012-11-26 13:27 ` [RFC v1 12/15] hfp_hf: Request secure connections Claudio Takahasi
2012-11-26 13:27 ` [RFC v1 13/15] bluetooth: Fix memory leak of adapter_any_path Claudio Takahasi
2012-11-26 13:27 ` [RFC v1 14/15] hfp_hf: Handle connections before probe Claudio Takahasi
2012-11-26 13:27 ` [RFC v1 15/15] bluetooth: Fix memory leak of UUIDs list Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 00/14] External HFP Profile Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 01/14] hfp_hf: Add HFP external Profile registration Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 02/14] hfp_hf: Add BlueZ Profile handler Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 03/14] hfp_hf: Add parsing of Profile NewConnection call Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 04/14] hfp_hf: Add SLC setup Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 05/14] hfp_hf: Add Profile1 Release Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 06/14] hfp_hf: Remove HandsfreeAgent and HandsfreeGateway Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 07/14] hfp_hf: Register HFP modem dynamically Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 08/14] hfp_hf: Fix updating alias Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 09/14] bluetooth: Reuse D-Bus dictionary parser function Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 10/14] hfp_hf: Add Version and Features parsing Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 11/14] bluetooth: Use generic function to parse dict Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 12/14] bluetooth: Fix memory leak of adapter_any_path Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 13/14] hfp_hf: Handle connections before probe Claudio Takahasi
2012-12-03 13:11 ` [PATCH v0 14/14] bluetooth: Fix memory leak of UUIDs list Claudio Takahasi
2012-12-17 14:28 ` [PATCH v0 00/14] External HFP Profile Claudio Takahasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123085432.GA4850@x220 \
--to=johan.hedberg@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.