From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH V2 2/2] mfd: stmpe: Extend DT support in stmpe driver Date: Fri, 23 Nov 2012 09:33:52 +0000 Message-ID: <20121123093352.GC17471@gmail.com> References: <20121122112451.GE4328@gmail.com> <20121122154612.GC10986@gmail.com> <20121123034557.GB5384@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20121123034557.GB5384-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Shiraz Hashim Cc: sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Viresh Kumar , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org T24gRnJpLCAyMyBOb3YgMjAxMiwgU2hpcmF6IEhhc2hpbSB3cm90ZToKCj4gT24gVGh1LCBOb3Yg MjIsIDIwMTIgYXQgMTA6MzE6NDhQTSArMDUzMCwgVmlyZXNoIEt1bWFyIHdyb3RlOgo+ID4gT24g MjIgTm92ZW1iZXIgMjAxMiAyMToxNiwgTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4g d3JvdGU6Cj4gPiA+IFRoZSBTVE1QRSBHUElPIGNvbnRyb2xsZXIgY2FuJ3QgYmUgdXNlZCBieSBE ZXZpY2UgVHJlZSB5ZXQgaW4KPiA+ID4gYW55IGNhc2UsIGJlY2F1c2UgaXQgZG9lc24ndCBoYXZl IGFuIElSUSBkb21haW4uIFRoaXMgaXMKPiA+ID4gY29tcHVsc29yeSwgb3IgaXQgd29uJ3Qgd29y ay4gSGF2ZSB5b3UgdHJpZWQgdG8gdGVzdCB0aGlzCj4gPiA+IGZ1bmN0aW9uYWxpdHkgeWV0Pwo+ ID4gCj4gPiBJIGRvbid0IGhhdmUgU1BFQXIgYm9hcmQgdG8gdGVzdCBpdCBhbnltb3JlLiBJIGhh dmUgbW92ZWQgb3V0IG9mCj4gPiBTVCBub3cgYW5kIHdvcmtpbmcgaW4gbGluYXJvIGFzIEFSTSBh c2lnbmVlLiBKdXN0IHB1c2hpbmcgdGhlc2UKPiA+IGFzIGFuIHBhcnQgdGltZSBhY3Rpdml0eS4K PiA+IAo+ID4gVGhvdWdoIFNUIGd1eXMgd291bGQgaGF2ZSB0ZXN0ZWQgc3RtcGUsIGJ1dCBzdG1w ZS1ncGlvLCBpIGFtIG5vdAo+ID4gc3VyZSBhYm91dC4KPiAKPiBMZXQgbWUgYnJpbmcgc29tZSBt b3JlIGluZm9ybWF0aW9uIGhlcmUuIEkgdG90YWxseSB1bmRlcnN0YW5kCj4gSm9uZXMgY29uY2Vy bnMsIGJ1dCB0aGUgd2F5IHN0bXBlIChhbmQgbWF5IGJlIG90aGVyIG1mZCBkZXZpY2VzKQo+IGFy ZSBoYW5kbGVkIGlzIHRoaXMgdGhhdCB0aGUgcGFyZW50IGJsb2NrIChpLmUuIHN0bXBlKSBkZWNp ZGVzIG9uCj4gdGhlIHZhcmlhbnRzIChzYXkgYnkgcHJvYmluZyBkZXZpY2UgaXRzZWxmKSBhbmQg dGhlbiBwcmVwYXJlcwo+IGFzc29jaWF0ZWQgZGF0YSBmb3IgdGhlIChwcm9iZWQpIHZhcmlhbnQg YW5kIGNyZWF0ZXMgYSBwbGF0Zm9ybQo+IGRldmljZSBmb3IgdGhlIHNhbWUuCgpJIHJlYWxpc2Ug dGhpcywgYnV0IG5vdyB3ZSdyZSB1c2luZyBEZXZpY2UgVHJlZSwgdGhlcmUncyBubyBuZWVkCnRv IHN0dWZmIHBkYXRhIGluIHRoZSBwYXJlbnQgZHJpdmVyIG5vdy4gSXQncyBiZXR0ZXIgdGhhdCB0 aGUKY2hpbGQgZGV2aWNlcyBhcmUgc2VsZiBzdWZmaWNpZW50LgoKPiBGb3IgdGhlIGludGVycnVw dHMgY2FzZSBhbHNvLCBpdCBpcyBzdG1wZSB3aGljaCByZWdpc3RlcnMgdGhlCj4gaXJxIGRvbWFp bi4gVGhpcyBpcyBiZWNhdXNlLCBzdG1wZSBkcml2ZXIgcHJvYmVzIHZhcmlhbnQgYW5kCj4gcG9w dWxhdGVzIGl0cyBwbGF0Zm9ybSBkYXRhIGFuZCBzdG1wZS1ncGlvIG1heSBub3QgYmUgYXdhcmUg b2YgdGhlCj4gdmFyaWFudCBpdCBzZXJ2ZXMuIEF0IHRoZSBzYW1lIHRpbWUsIGl0IChzdG1wZSkg bmVlZHMgZmV3IG9mIHRoZQo+ICh2aXJ0dWFsKSBpbnRlcnJ1cHRzIGZvciBpdHMgaW50ZXJuYWwg cHVycG9zZSBhbHNvLgoKSSBrbm93LiBJIHdyb3RlIHRoZSBJUlEgZG9tYWluIGZvciBTVE1QRS4g OykKClNUTVBFIG5lZWRzIGl0cyBvd24gb25lIHRvbywgd2hpY2ggSSB3aWxsIHdvcmsgb24gbm93 LgoKU1RNUEUtR1BJTyBkb2Vzbid0IG5lZWQgdG8gYmUgYXdhcmUgb2YgYW55dGhpbmcsIHRoZSBk ZXZpY2UKd2hpY2ggd2lzaGVzIHRvIHVzZSBpdHMgR1BJT3MvSVJRcyB3aWxsIHJlZmVyZW5jZSBp dCBmcm9tCkRldmljZSBUcmVlIGluIHRoZSBtYW5vciBwcmV2aW91c2x5IGV4cGxhaW5lZC4KCj4g SGVuY2Ugc3RtcGUgcGFzc2VzIGlycV9iYXNlIHRvIHRoZSBzdG1wZS1ncGlvIGRyaXZlciB3aGls ZQo+IGFsbG9jYXRpbmcgYW5kIHJlZ2lzdGVyaW5nIGlycSBkb21haW4gYnkgaXRzZWxmLgoKTm90 IGFueW1vcmUgaXQgZG9lc24ndC4gVGhlcmUgYXJlIG5vIGlycV9iYXNlOnMgd2l0aCBEVC4gQWxs CklSUXMgYXJlIGR5bmFtaWMsIGhlbmNlIHdoeSBTVE1QRSByZXF1aXJlcyBpdHMgb3duIGRvbWFp biB0bwpwbGF5IHdpdGguIEkgY2FuIGZpeCB0aGF0LgoKPiBXaXRoIHRoaXMgYXBwcm9hY2ggd2Ug aGF2ZSB0ZXN0ZWQgdGhlIGZ1bmN0aW9uYWxpdHkgb24gU1BFQXIKPiBwbGF0Zm9ybS4KCllvdSds bCBuZWVkIHRvIHRlc3QgaXQgYWdhaW4gd2l0aCB0aGUgbmV3IERUIGFwcHJvYWNoIHRvby4gOikK Ci0tIApMZWUgSm9uZXMKTGluYXJvIFNULUVyaWNzc29uIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFy by5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJv OiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRldmljZXRyZWUtZGlzY3VzcyBtYWlsaW5nIGxpc3QKZGV2aWNl dHJlZS1kaXNjdXNzQGxpc3RzLm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xp c3RpbmZvL2RldmljZXRyZWUtZGlzY3Vzcwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759082Ab2KWJeB (ORCPT ); Fri, 23 Nov 2012 04:34:01 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:50901 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759018Ab2KWJd6 (ORCPT ); Fri, 23 Nov 2012 04:33:58 -0500 Date: Fri, 23 Nov 2012 09:33:52 +0000 From: Lee Jones To: Shiraz Hashim Cc: Viresh Kumar , sameo@linux.intel.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com, Vipul Kumar Samar Subject: Re: [PATCH V2 2/2] mfd: stmpe: Extend DT support in stmpe driver Message-ID: <20121123093352.GC17471@gmail.com> References: <20121122112451.GE4328@gmail.com> <20121122154612.GC10986@gmail.com> <20121123034557.GB5384@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20121123034557.GB5384@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Nov 2012, Shiraz Hashim wrote: > On Thu, Nov 22, 2012 at 10:31:48PM +0530, Viresh Kumar wrote: > > On 22 November 2012 21:16, Lee Jones wrote: > > > The STMPE GPIO controller can't be used by Device Tree yet in > > > any case, because it doesn't have an IRQ domain. This is > > > compulsory, or it won't work. Have you tried to test this > > > functionality yet? > > > > I don't have SPEAr board to test it anymore. I have moved out of > > ST now and working in linaro as ARM asignee. Just pushing these > > as an part time activity. > > > > Though ST guys would have tested stmpe, but stmpe-gpio, i am not > > sure about. > > Let me bring some more information here. I totally understand > Jones concerns, but the way stmpe (and may be other mfd devices) > are handled is this that the parent block (i.e. stmpe) decides on > the variants (say by probing device itself) and then prepares > associated data for the (probed) variant and creates a platform > device for the same. I realise this, but now we're using Device Tree, there's no need to stuff pdata in the parent driver now. It's better that the child devices are self sufficient. > For the interrupts case also, it is stmpe which registers the > irq domain. This is because, stmpe driver probes variant and > populates its platform data and stmpe-gpio may not be aware of the > variant it serves. At the same time, it (stmpe) needs few of the > (virtual) interrupts for its internal purpose also. I know. I wrote the IRQ domain for STMPE. ;) STMPE needs its own one too, which I will work on now. STMPE-GPIO doesn't need to be aware of anything, the device which wishes to use its GPIOs/IRQs will reference it from Device Tree in the manor previously explained. > Hence stmpe passes irq_base to the stmpe-gpio driver while > allocating and registering irq domain by itself. Not anymore it doesn't. There are no irq_base:s with DT. All IRQs are dynamic, hence why STMPE requires its own domain to play with. I can fix that. > With this approach we have tested the functionality on SPEAr > platform. You'll need to test it again with the new DT approach too. :) -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog