Re: [PATCH V2 2/2] mfd: stmpe: Extend DT support in stmpe driver

[Lee Jones <lee.jones@linaro.org>]

On Fri, 23 Nov 2012, Viresh Kumar wrote:

> On 22 November 2012 16:54, Lee Jones <lee.jones@linaro.org> wrote:
> >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt b/Documentation/devicetree/bindings/mfd/stmpe.txt
> >>       stmpe1601: stmpe1601@40 {
> 
> >> +             id = <0>;
> >
> > Don't do this. Device IDs are Linux specific.
> 
> Hi Lee,
> 
> This is id of the mfd device that we need to pass to mfd_add_device()
> and is used in following:

MFD devices are Linux specific, whereas DT is cross-platform. Thus
you can't put it in the DTS(I) files.

> 	pdev = platform_device_alloc(cell->name, id + cell->id);
> 
> This is required when we have multiple instances of MFD device present
> on board. How do you want me to handle this ?

There are lots of examples of this already. I have to leave something
to the imagination, or I'll be requesting a cut of your salary. :D

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog