From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines Date: Fri, 23 Nov 2012 09:40:44 +0000 Message-ID: <20121123094044.GF17471@gmail.com> References: <20121122102710.GD4328@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Viresh Kumar Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org T24gVGh1LCAyMiBOb3YgMjAxMiwgVmlyZXNoIEt1bWFyIHdyb3RlOgoKPiBPbiAyMiBOb3ZlbWJl ciAyMDEyIDE1OjU3LCBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPiB3cm90ZToKPiA+ IE9uIFRodSwgMjIgTm92IDIwMTIsIFZpcmVzaCBLdW1hciB3cm90ZToKPiA+Cj4gPj4gVGhpcyBw YXRjaCBmcmVlcyBzdG1wZSBkcml2ZXIgZnJvbSB0ZW5zaW9uIG9mIGZyZWVpbmcgcmVzb3VyY2Vz IDopCj4gPj4gZGV2bV8qIGRlcml2YXRpdmVzIG9mIG11bHRpcGxlIHJvdXRpbmVzIGFyZSB1c2Vk IHdoaWxlIGFsbG9jYXRpbmcgcmVzb3VyY2VzLAo+ID4+IHdoaWNoIHdvdWxkIGJlIGZyZWVkIGF1 dG9tYXRpY2FsbHkgYnkga2VybmVsLgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogVmlyZXNoIEt1 bWFyIDx2aXJlc2gua3VtYXJAbGluYXJvLm9yZz4KPiAKPiA+IEFja2VkLWJ5OiBMZWUgSm9uZXMg PGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+IAo+IEhpIFNhbWVvLAo+IAo+IFBsZWFzZSBhcHBseSB0 aGlzIHBhdGNoIG9ubHkgZnJvbSB0aGlzIHNlcmllcy4gSSB3aWxsIG5vdCByZXNlbmQgaXQgaW4K PiBWMyBvZiBteSBzZXQuCgpUaGF0J3Mgbm90IGhvdyBpdCB3b3Jrcy4KCkFwcGx5IG15IEFja2Vk LWJ5IHlvdXJzZWxmIGFuZCByZS1zZW5kIHRoZSBwYXRjaC1zZXQgYXMgYSB3aG9sZS4KCi0tIApM ZWUgSm9uZXMKTGluYXJvIFNULUVyaWNzc29uIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg 4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNl Ym9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRldmljZXRyZWUtZGlzY3VzcyBtYWlsaW5nIGxpc3QKZGV2aWNldHJlZS1k aXNjdXNzQGxpc3RzLm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZv L2RldmljZXRyZWUtZGlzY3Vzcwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759174Ab2KWJkw (ORCPT ); Fri, 23 Nov 2012 04:40:52 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:64176 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759130Ab2KWJkt (ORCPT ); Fri, 23 Nov 2012 04:40:49 -0500 Date: Fri, 23 Nov 2012 09:40:44 +0000 From: Lee Jones To: Viresh Kumar Cc: sameo@linux.intel.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com Subject: Re: [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines Message-ID: <20121123094044.GF17471@gmail.com> References: <20121122102710.GD4328@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Nov 2012, Viresh Kumar wrote: > On 22 November 2012 15:57, Lee Jones wrote: > > On Thu, 22 Nov 2012, Viresh Kumar wrote: > > > >> This patch frees stmpe driver from tension of freeing resources :) > >> devm_* derivatives of multiple routines are used while allocating resources, > >> which would be freed automatically by kernel. > >> > >> Signed-off-by: Viresh Kumar > > > Acked-by: Lee Jones > > Hi Sameo, > > Please apply this patch only from this series. I will not resend it in > V3 of my set. That's not how it works. Apply my Acked-by yourself and re-send the patch-set as a whole. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog