From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] xend: enable environment passing in xPopen3
Date: Fri, 23 Nov 2012 11:52:42 +0100
Message-ID: <20121123105242.GA16420@aepfle.de>
References: <a446956472330fe32bc6.1353530980@probook.site>
	<1353665411.13542.197.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1353665411.13542.197.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, Nov 23, Ian Campbell wrote:

> On Wed, 2012-11-21 at 20:49 +0000, Olaf Hering wrote:
> > # HG changeset patch
> > # User Olaf Hering <olaf@aepfle.de>
> > # Date 1353530937 -3600
> > # Node ID a446956472330fe32bc69be764a33f59fb090792
> > # Parent  2489c29266982175b5b4e945c97b4549360e947f
> > xend: enable environment passing in xPopen3
> > 
> > In changeset 19990:38dd208e1d95 a new parameter 'env' was added to
> > xPopen3, but no code was added to actually pass the environment down to
> > execvpe. Also, the new code was unreachable.
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> It seems that no callers provide an environment? How did you spot this?

In my testing I did pass options to xc_save via the environment, which
is called via forkhelper (somewhere in python code).

Olaf