From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/i915: set the AVI VIC of the HDMI mode Date: Fri, 23 Nov 2012 14:50:37 +0100 Message-ID: <20121123135037.GA2612@avionic-0098.adnet.avionic-design.de> References: <1353512389-16261-1-git-send-email-przanoni@gmail.com> <20121122064648.GA22143@avionic-0098.adnet.avionic-design.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1748050789==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1748050789== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 23, 2012 at 11:46:10AM -0200, Paulo Zanoni wrote: > Hi >=20 > 2012/11/22 Thierry Reding : > > On Wed, Nov 21, 2012 at 01:39:48PM -0200, Paulo Zanoni wrote: [...] > >> + * @mode: mode > >> + * > >> + * RETURNS: > >> + * The VIC number, 0 in case it's not a CEA-861 mode. > >> + */ > >> +uint8_t drm_mode_cea_vic(const struct drm_display_mode *mode) > > > > I understand the reason for returning an uint8_t here, but ... > > > >> +{ > >> + uint8_t i; > >> + > >> + for (i =3D 0; i < drm_num_cea_modes; i++) > > > > ... maybe unsigned int would be better for the iteration variable here. > > Looking at drm_edid_modes.h, drm_num_cea_modes is actually signed, which > > isn't necessary to store an array size, so maybe that should be changed > > as well. >=20 > I used uint8_t because "i" is the thing we return. I don't think > there's a perfect solution to this problem and I don't really think it > matters too much. Fair enough, uint8_t should work fine. Thierry --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQr38sAAoJEN0jrNd/PrOhcD0P/2ljMxHA59aBphNlBw0EeKoz Vvupw3daFzccyQVC3djAXbLE9OJpSlah9jR8BpVtPUZKKg2g94z1ysoCd+QgIkIN vGA2G+DrvJoKFkq9Hw4hg9GJVMmR8CZGFQ9GpK1t6pS4y8VK6Ban+Xju3FMiafrj zR97JO4LaQPrB9tuqRN2VyGFlLcizuHMa/ADQdIg2MK7KbpFpjP9bT/hHpJVdnqA y8JBSVI9Y56bRV5o3ImjVngoCCBSnDBKAPH6ox3J59FuPzOEtSaAnjvNDzjvL+6n pvlQw7SF6OmsQz9liFZy5gnQFxKjEWuGBirdIxR4JsE9QhO9vGLpXyoNPjFPufa7 B5mcWbdvf4P5O31CGZ5nbGUIPA9VXpqL4x6s3eSaQUu5lDlKN3S0TySt7YfbjMGK nd8Ag9NiKRp2gjA6lSQFvyR90ovvCLPPOWd1lXzooJz66ttSUIcOI1sAx7qjKCZv ff7cxinMEC+l7DCTCI28R30WCHeOglmEfx+Is2Zi5r4jENPP6BdgekGYIIBPFOjY fizypbCA1/PJIG1rruWAG4NeSbgIrFVWOkan/wh14rZWSW+1uYMNVv5V2fE8Cf+o qPjMAbAYWx8UFOzeut4O/uqL/NsEGEl3k9PVg2eBDW2nQ207sX0DI3LKTscEojjT QWrnV1KX+IDko23HmKB1 =wIil -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS-- --===============1748050789== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1748050789==--