All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Maiolino <cmaiolino@redhat.com>
To: Ric Wheeler <rwheeler@redhat.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
	"Theodore Ts'o" <tytso@mit.edu>,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: check incompatible mount options when mounting ext2/3
Date: Fri, 23 Nov 2012 14:20:09 -0200	[thread overview]
Message-ID: <20121123162009.GA10760@andromeda.usersys.redhat.com> (raw)
In-Reply-To: <50A54AAC.8050100@redhat.com>

Hi, sorry my delayed answer on this thread.

> >Anyway, back to my main point:  As a guiding principle I think I would
> >say that mount -t ext3 with ext4.ko should hard-reject any option not
> >understood by ext3.ko.  It's clear and predictable, and should make for
> >a decent first cut.
> >
> >-Eric
> 
> Agreed (sounds almost like we had coordinated our answers before I
> spoke to Ted in Barcelona!).
> 
> Ric
> 
that's my main point, and the goal of my first patch. I was thinking in just
warn when mounting a ext3 with ext4.ko using mount options not recognized by
ext3.ko, but, looks like hard-reject these options looks more reasonable than
just warning.

I'm going to re-write the patch using this approach. Is there any concern in
take this direction from any part here?

-- 
Carlos

  reply	other threads:[~2012-11-23 16:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01 19:32 [PATCH] ext4: check incompatible mount options when mounting ext2/3 Carlos Maiolino
2012-11-08 17:02 ` Theodore Ts'o
2012-11-11 22:16   ` Eric Sandeen
2012-11-15 20:03     ` Ric Wheeler
2012-11-23 16:20       ` Carlos Maiolino [this message]
2013-01-22 16:07 ` [PATCH] ext4: check incompatible mount options when mounting ext2/3 [V2] Carlos Maiolino
2013-01-23 10:39   ` Jan Kara
2013-01-23 12:22     ` Carlos Maiolino
2013-01-23 13:00       ` Jan Kara
2013-10-31 14:00         ` Carlos Maiolino
2013-11-19 18:39           ` Carlos Maiolino
2013-11-22  1:43             ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121123162009.GA10760@andromeda.usersys.redhat.com \
    --to=cmaiolino@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=rwheeler@redhat.com \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.