From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Date: Fri, 23 Nov 2012 21:59:46 +0000 Subject: Re: [PATCH] of/address: sparc: Declare of_iomap as an extern function for sparc again Message-Id: <20121123215947.02DDC3E1EC4@localhost> List-Id: References: <1353669849-23697-1-git-send-email-andreas@gaisler.com> <20121123.142110.835354734152648777.davem@davemloft.net> In-Reply-To: <20121123.142110.835354734152648777.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller , andreas@gaisler.com Cc: sam@ravnborg.org, rob.herring@calxeda.com, sparclinux@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, software@gaisler.com On Fri, 23 Nov 2012 14:21:10 -0500 (EST), David Miller wrote: > From: Andreas Larsson > Date: Fri, 23 Nov 2012 12:24:09 +0100 > > > This bug-fix makes sure that of_iomap is defined extern for sparc so that the > > sparc-specific implementation of_iomap is once again used when including > > include/linux/of_address.h in a sparc context. OF_GPIO that is now available for > > sparc relies on this. > > > > The bug was inadvertently introduced in a850a75, "of/address: add empty static > > inlines for !CONFIG_OF", that added a static dummy inline for of_iomap when > > !CONFIG_OF_ADDRESS. However, CONFIG_OF_ADDRESS is never defined for sparc, but > > there is a sparc-specific implementation /arch/sparc/kernel/of_device_common.c. > > > > This fix takes the same approach as 0bce04b that solved the equivalent problem > > for of_address_to_resource. > > > > Signed-off-by: Andreas Larsson > > Grant, can you possibly merge this to Linus while I'm travelling? > That would help me a lot. Yup, I'm doing it right now. g.