From: Sergei Trofimovich <slyich@gmail.com>
To: bo.li.liu@oracle.com
Cc: btrfs <linux-btrfs@vger.kernel.org>,
Marios Titas <redneb8888@gmail.com>,
dsterba@suse.cz, Chris Mason <chris.mason@fusionio.com>
Subject: Re: per-file NOCOW in 3.7
Date: Fri, 23 Nov 2012 23:54:32 +0300 [thread overview]
Message-ID: <20121123235432.1fd1099e@sf> (raw)
In-Reply-To: <20121122011653.GC3327@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
> > > According to the tentative changelog in the wiki, 3.7 will properly
> > > support per-file NOCOW. I think this is misleading. In particular, it
> > > still does not work correctly in the case when the NOCOW flag of a new
> > > flag is being inherited from the directory. I think it would be better
> > > to remove that item from the changelog until the the fix [1] is
> > > merged.
> > > [1] https://patchwork.kernel.org/patch/1438431/
> >
> > You're right, the patch is not in 3.7-rc nor in btrfs-next, and fixes a
> > real bug.
> >
> > Technically it is a regresssion within the 3.7 cycle (so it could even
> > go to a late -rc), in any case it's a small change that could also go
> > through the stable tree.
> >
> > david
>
> Well, I'll resend it for merge with Marios's reported-by and your Reviewed-by.
>
> Don't worry, it's a good fix though.
I'm using your patch on 2 boxes for 2 months.
It is the only way to get decent performance
on my workload.
Thanks for the patch!
Tested-by: Sergei Trofimovich <slyich@gmail.com>
--
Sergei
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2012-11-23 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 15:48 per-file NOCOW in 3.7 Marios Titas
2012-11-21 17:25 ` David Sterba
2012-11-22 1:16 ` Liu Bo
2012-11-23 20:54 ` Sergei Trofimovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123235432.1fd1099e@sf \
--to=slyich@gmail.com \
--cc=bo.li.liu@oracle.com \
--cc=chris.mason@fusionio.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=redneb8888@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.