From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47199)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TcEsy-0006Wm-RP
	for qemu-devel@nongnu.org; Sat, 24 Nov 2012 07:31:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TcEsx-0002ru-OJ
	for qemu-devel@nongnu.org; Sat, 24 Nov 2012 07:31:04 -0500
Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:48377)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TcEsx-0002ro-HK
	for qemu-devel@nongnu.org; Sat, 24 Nov 2012 07:31:03 -0500
Date: Sat, 24 Nov 2012 13:30:51 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20121124123051.GC4016@ohm.aurel32.net>
References: <20121121055045.GA33849@cs.nctu.edu.tw>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20121121055045.GA33849@cs.nctu.edu.tw>
Subject: Re: [Qemu-devel] [PATCH v2] target-mips: Add comments on POOL32Axf
	encoding
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?utf-8?B?6Zmz6Z+L5Lu7IChXZWktUmVuIENoZW4p?= <chenwj@iis.sinica.edu.tw>
Cc: Jia Liu <proljc@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "Johnson, Eric" <ericj@mips.com>

On Wed, Nov 21, 2012 at 01:50:45PM +0800, 陳韋任 (Wei-Ren Chen) wrote:
>   Current QEMU MIPS POOL32AXF encoding comes from microMIPS32
> and microMIPS32 DSP. Add comment here to help reading.
> 
> Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
> ---
> 
> v2: Correct commit message formatting
> 
>  target-mips/translate.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)

Thanks, applied.

> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index 8b438f8..e453d9e 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -10359,6 +10359,19 @@ enum {
>  
>  /* POOL32AXF encoding of minor opcode field extension */
>  
> +/*
> + * 1. MIPS Architecture for Programmers Volume II-B:
> + *      The microMIPS32 Instruction Set (Revision 3.05)
> + *
> + *    Table 6.5 POOL32Axf Encoding of Minor Opcode Extension Field
> + *
> + * 2. MIPS Architecture for Programmers VolumeIV-e:
> + *      The MIPS DSP Application-Specific Extension
> + *        to the microMIPS32 Architecture (Revision 2.34)
> + *
> + *    Table 5.5 POOL32Axf Encoding of Minor Opcode Extension Field
> + */ 
> +
>  enum {
>      /* bits 11..6 */
>      TEQ = 0x00,
> @@ -10371,6 +10384,8 @@ enum {
>      MFC0 = 0x03,
>      MTC0 = 0x0b,
>  
> +    /* begin of microMIPS32 DSP */
> +
>      /* bits 13..12 for 0x01 */
>      MFHI_ACC = 0x0,
>      MFLO_ACC = 0x1,
> @@ -10387,6 +10402,8 @@ enum {
>      MULT_ACC = 0x0,
>      MULTU_ACC = 0x1,
>  
> +    /* end of microMIPS32 DSP */
> +
>      /* bits 15..12 for 0x2c */
>      SEB = 0x2,
>      SEH = 0x3,
> -- 
> 1.7.12.3
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net