From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx23: Add POWER and CLKCTRL register definitions
Date: Sun, 25 Nov 2012 04:06:43 +0100 [thread overview]
Message-ID: <201211250406.43291.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKrkr0jBSTVQA_qRsQTkL1o34JAjHwwkmCfZLOuVuvqoZg@mail.gmail.com>
Dear Otavio Salvador,
> On Sun, Nov 25, 2012 at 12:54 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> >
> >> On Sat, Nov 24, 2012 at 10:21 PM, Marek Vasut <marex@denx.de> wrote:
> >> > Add register definitions for the i.MX23 power control block and
> >> > clock control block. These are essential for the basic bootstrap
> >> > of the i.MX23. Also, properly include them in imx-regs.h .
> >> >
> >> > Signed-off-by: Marek Vasut <marex@denx.de>
> >> > Cc: Stefano Babic <sbabic@denx.de>
> >>
> >> Please don't merge it now as this has been already done in my branch
> >> with mx23.
> >
> > I'm attaching a proper diff against your branch. There are multiple wrong
> > and missing bits in your branch. This patch is done by processing the
> > FSL-provided header file and cross-checking with the datasheet.
> >
> > So, this patch is right, yours is wrong. Sorry.
>
> I am not saying mine is perfect, far from it. And we can fix it in the
> branch but please don't push it until we finish mx23 bootstrap.
>
> Let's work in same code, not duplicate work...
I still don't see any argument against applying this patch -- other than the
fact it will break some out-of-tree port.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-11-25 3:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 0:21 [U-Boot] [PATCH] mx23: Add POWER and CLKCTRL register definitions Marek Vasut
2012-11-25 2:52 ` Otavio Salvador
2012-11-25 2:54 ` Marek Vasut
2012-11-25 2:57 ` Otavio Salvador
2012-11-25 3:06 ` Marek Vasut [this message]
2012-11-25 18:10 ` Otavio Salvador
2012-11-25 18:17 ` Marek Vasut
2012-12-04 7:59 ` Stefano Babic
2012-12-04 11:09 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211250406.43291.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.