From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 25 Nov 2012 20:40:48 +0100 Subject: [U-Boot] [PATCH 01/22] ARM: sunxi: Basic Allwinner A10/A13 (sun4i/sun5i) support In-Reply-To: <1353843450.17518.13.camel@home.hno.se> References: <1353843450.17518.13.camel@home.hno.se> Message-ID: <20121125194048.757CE20105B@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Henrik Nordstr?m, In message <1353843450.17518.13.camel@home.hno.se> you wrote: > This adds support for the Allwinner A10/A13 SoC's. Additionally > board support for the dev-boards sun4i/sun5i is added. ... > +/* Return PLL5 frequency in Hz > + * Note: Assumes PLL5 reference is 24MHz clock > + */ Incorrect multiline comment style. Please fix globally. > diff --git a/include/configs/sun4i.h b/include/configs/sun4i.h > new file mode 100644 > index 0000000..513f618 ... > +#define CONFIG_MACH_TYPE 4104 NAK. Please use value from mach-types.h ; if needed, ask for an update. > diff --git a/include/configs/sun5i.h b/include/configs/sun5i.h > new file mode 100644 > index 0000000..dc84aba ... > +#define CONFIG_MACH_TYPE 4138 Ditto. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "It may be that our role on this planet is not to worship God but to create him." - Arthur C. Clarke