From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Increase the response time for slow SDVO devices Date: Mon, 26 Nov 2012 19:45:49 +0100 Message-ID: <20121126184548.GC32309@phenom.ffwll.local> References: <874nkgh7f5.fsf@intel.com> <1353671876-13852-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 3CC8BE637D for ; Mon, 26 Nov 2012 10:44:26 -0800 (PST) Received: by mail-ee0-f49.google.com with SMTP id c4so4741731eek.36 for ; Mon, 26 Nov 2012 10:44:25 -0800 (PST) Content-Disposition: inline In-Reply-To: <1353671876-13852-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Nov 23, 2012 at 11:57:56AM +0000, Chris Wilson wrote: > Some devices may respond very slowly and only flag that the reply is > pending within the first 15us response window. Be kind to such devices > and wait a further 15ms, before checking for the pending reply. This > moves the existing special case delay of 30ms down from the detection > routine into the common path and pretends to explain it... > > v2: Simplify the loop constructs as suggested by Jani Nikula. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=36997 > Signed-off-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch