From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: Document no-sleep requirement for playback() callback
Date: Tue, 27 Nov 2012 06:47:41 +0000 [thread overview]
Message-ID: <20121127064741.GW9411@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121127064238.GA1989@core.coreip.homeip.net>
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
On Mon, Nov 26, 2012 at 10:42:38PM -0800, Dmitry Torokhov wrote:
> We already have a few lines below:
> > * Note that playback(), set_gain() and set_autocenter() are called with
> > * dev->event_lock spinlock held and interrupts off and thus may not
> > * sleep.
> So I doubt they will pay more attention to your addition ;)
Ah, it's quite a few lines below - it was actually off the bottom of my
screen which rather buried the lead (though TBH I think I was most
surprised by the fact that the lock isn't actually in the struct).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-11-27 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 6:32 [PATCH] Input: Document no-sleep requirement for playback() callback Mark Brown
2012-11-27 6:42 ` Dmitry Torokhov
2012-11-27 6:47 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121127064741.GW9411@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.