From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/9] Generate appropriate responses for DFU
Date: Wed, 28 Nov 2012 03:46:04 +0100 [thread overview]
Message-ID: <201211280346.04338.marex@denx.de> (raw)
In-Reply-To: <1354106642-4587-6-git-send-email-panto@antoniou-consulting.com>
Dear Pantelis Antoniou,
> Make sure appropriate responses for the DFU protocal are
> generated.
I dont understand this patch, please explain it properly in the commit message.
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
> drivers/usb/gadget/composite.c | 9 +++++++++
> drivers/usb/gadget/ep0.c | 1 +
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/usb/gadget/composite.c
> b/drivers/usb/gadget/composite.c index ebb5131..1ae318c 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -773,6 +773,15 @@ composite_setup(struct usb_gadget *gadget, const
> struct usb_ctrlrequest *ctrl) if (value >= 0)
> value = min(w_length, (u16) value);
> break;
> +
> +#ifdef CONFIG_DFU_FUNCTION
> + case DFU_DT_FUNC: /* DFU */
> + value = config_desc(cdev, w_value);
> + if (value >= 0)
> + value = min(w_length, (u16) value);
> + break;
> +#endif
> +
> default:
> goto unknown;
> }
> diff --git a/drivers/usb/gadget/ep0.c b/drivers/usb/gadget/ep0.c
> index aa8f916..971d846 100644
> --- a/drivers/usb/gadget/ep0.c
> +++ b/drivers/usb/gadget/ep0.c
> @@ -221,6 +221,7 @@ static int ep0_get_descriptor (struct
> usb_device_instance *device, break;
>
> case USB_DESCRIPTOR_TYPE_CONFIGURATION:
> + case USB_DESCRIPTOR_TYPE_OTHER_SPEED_CONFIGURATION:
> {
> struct usb_configuration_descriptor
> *configuration_descriptor;
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-11-28 2:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 12:43 [U-Boot] [PATCH 0/9] DFU on am35xx_evm (against u-boot-usb) Pantelis Antoniou
2012-11-28 12:43 ` [U-Boot] [PATCH 1/9] Remove obsolete header file Pantelis Antoniou
2012-11-27 16:45 ` Tom Rini
2012-11-27 22:00 ` Marek Vasut
2012-11-28 3:01 ` Tom Rini
2012-11-28 12:43 ` [U-Boot] [PATCH 2/9] Fix bug when both DFU & ETHER are defined Pantelis Antoniou
2012-11-28 2:43 ` Marek Vasut
2012-11-28 8:24 ` Pantelis Antoniou
2012-11-29 6:30 ` Marek Vasut
2012-11-28 12:43 ` [U-Boot] [PATCH 3/9] Only perform DFU board_usb_init() for TRATS Pantelis Antoniou
2012-11-28 2:45 ` Marek Vasut
2012-11-28 8:26 ` Pantelis Antoniou
2012-11-29 6:28 ` Marek Vasut
2012-11-28 12:43 ` [U-Boot] [PATCH 4/9] Fix crash when wrong number of arguments given Pantelis Antoniou
2012-11-28 12:43 ` [U-Boot] [PATCH 5/9] Generate appropriate responses for DFU Pantelis Antoniou
2012-11-28 2:46 ` Marek Vasut [this message]
2012-11-28 8:27 ` Pantelis Antoniou
2012-11-28 12:43 ` [U-Boot] [PATCH 6/9] Properly zero out timeout value Pantelis Antoniou
2012-11-28 2:46 ` Marek Vasut
2012-11-28 8:28 ` Pantelis Antoniou
2012-11-28 10:23 ` Marek Vasut
2012-11-28 12:44 ` [U-Boot] [PATCH 7/9] Add a partition type target Pantelis Antoniou
2012-11-28 2:48 ` Marek Vasut
2012-11-28 8:31 ` Pantelis Antoniou
2012-11-28 9:22 ` Marek Vasut
2012-11-28 12:44 ` [U-Boot] [PATCH 8/9] Issue connect/disconnect as appropriate Pantelis Antoniou
2012-11-28 2:50 ` Marek Vasut
2012-11-28 3:03 ` Tom Rini
2012-11-28 12:44 ` [U-Boot] [PATCH 9/9] Add DFU config Pantelis Antoniou
2012-11-28 2:52 ` Marek Vasut
2012-11-28 3:04 ` Tom Rini
2012-11-28 8:32 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211280346.04338.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.