Re: [PATCH v2 1/6] x86: PIT connects to pin 2 of IOAPIC

[Gleb Natapov <gleb@redhat.com>]

On Wed, Nov 21, 2012 at 04:09:34PM +0800, Yang Zhang wrote:
> When PIT connects to IOAPIC, it route to pin 2 not pin 0.
> 
> Signed-off-by: Yang Zhang <yang.z.zhang@intel.com>
> ---
>  virt/kvm/ioapic.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
> index cfb7e4d..166c450 100644
> --- a/virt/kvm/ioapic.c
> +++ b/virt/kvm/ioapic.c
> @@ -181,7 +181,7 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int irq)
>  
>  #ifdef CONFIG_X86
>  	/* Always delivery PIT interrupt to vcpu 0 */
> -	if (irq == 0) {
> +	if (irq == 2) {
Hmm, this means all this time the code didn't work correctly which makes
me wonder if we need this hack at all.

>  		irqe.dest_mode = 0; /* Physical mode. */
>  		/* need to read apic_id from apic regiest since
>  		 * it can be rewritten */
> -- 
> 1.7.1

--
			Gleb.