From: Marcelo Tosatti <mtosatti@redhat.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: MMU: lazily drop large spte
Date: Wed, 28 Nov 2012 09:39:30 -0200 [thread overview]
Message-ID: <20121128113930.GA29825@amt.cnet> (raw)
In-Reply-To: <50B5A0CA.8060807@linux.vnet.ibm.com>
On Wed, Nov 28, 2012 at 01:27:38PM +0800, Xiao Guangrong wrote:
> On 11/18/2012 11:00 AM, Marcelo Tosatti wrote:
> map gfn 4? See corrected step 7 above.
> >>
> >> Ah, this is a real bug, and unfortunately, it exists in current
> >> code. I will make a separate patchset to fix it. Thank you, Marcelo!
> >
> > Is it? Hum..
> >
> > Anyway, it would be great if you can write a testcase (should be similar
> > in size to rmap_chain).
>
> Marcelo, is this patch acceptable?
Yes, can we get reexecute_instruction fix first? (which should then be
able to handle the case where a large read-only spte is created).
I'll merge the testcase later today.
next prev parent reply other threads:[~2012-11-28 11:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 9:59 [PATCH] KVM: MMU: lazily drop large spte Xiao Guangrong
2012-11-12 23:10 ` Marcelo Tosatti
2012-11-13 8:26 ` Xiao Guangrong
2012-11-14 14:37 ` Marcelo Tosatti
2012-11-14 23:17 ` Xiao Guangrong
2012-11-16 3:02 ` Marcelo Tosatti
2012-11-16 3:39 ` Xiao Guangrong
2012-11-16 3:56 ` Marcelo Tosatti
2012-11-16 4:46 ` Xiao Guangrong
2012-11-16 9:57 ` Marcelo Tosatti
2012-11-17 14:06 ` Xiao Guangrong
2012-11-18 3:00 ` Marcelo Tosatti
2012-11-28 5:27 ` Xiao Guangrong
2012-11-28 11:39 ` Marcelo Tosatti [this message]
2012-11-13 15:33 ` Takuya Yoshikawa
2012-11-14 14:44 ` Marcelo Tosatti
2012-11-14 23:33 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128113930.GA29825@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.