Re: [PATCH 1/1] regmap: Add support for continously numbered pages across regmap range

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

On Wed, Nov 28, 2012 at 11:52:22AM +0000, Navada Kanyana, Mukund wrote:

> static const struct regmap_range_cfg aic325x_ranges[] = {
>         { .name = "CONF", .range_min = 128,
>           .range_max = 383,
>           .selector_reg = 0x0,
>           .selector_mask = 0xff,
>           .selector_shift = 0,
>           .window_start = 0, .window_len =128,
>         },
>         { .name = "MINIDSP_A_CM_A", .range_min = AIC325X_ADSP_CM_A_BASE,
>           .range_max = AIC325X_ADSP_CM_A_BASE + 1152,
>           .selector_reg = 0x0,
>           .selector_mask = 0xff,
>           .selector_shift = 0,
>           .window_start = 0, .window_len =128,
>         },
> };

You appear to have two different ranges with the same selector and
window.  I'm really not sure why you expect this to work...  what
happens when someone reads from the two different ranges simultaneously?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]