From: Christoph Hellwig <hch@infradead.org>
To: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Hin-Tak Leung <htl10@users.sourceforge.net>
Subject: Re: [PATCH] hfsplus: rework processing of return value of bio_alloc() in hfsplus_submit_bio()
Date: Wed, 28 Nov 2012 08:22:33 -0500 [thread overview]
Message-ID: <20121128132233.GA30413@infradead.org> (raw)
In-Reply-To: <1354108699.2017.7.camel@slavad-ubuntu>
On Wed, Nov 28, 2012 at 05:18:19PM +0400, Vyacheslav Dubeyko wrote:
> I don't insist on the patch. But if the function has such description:
>
> * RETURNS:
> * Pointer to new bio on success, NULL on failure.
>
> I prefer to check on NULL anyway. :-)
Check the sentence a couple lines above in the same comment:
* When @bs is not NULL, if %__GFP_WAIT is set then bio_alloc will always be
* able to allocate a bio. This is due to the mempool guarantees.
next prev parent reply other threads:[~2012-11-28 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 9:27 [PATCH] hfsplus: rework processing of return value of bio_alloc() in hfsplus_submit_bio() Vyacheslav Dubeyko
2012-11-28 12:48 ` Christoph Hellwig
2012-11-28 13:18 ` Vyacheslav Dubeyko
2012-11-28 13:22 ` Christoph Hellwig [this message]
2012-11-28 13:37 ` Vyacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128132233.GA30413@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=htl10@users.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.