From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v2 4/4] drm/i915: Kill
 i915_gem_execbuffer_wait_for_flips()
Date: Wed, 28 Nov 2012 21:56:56 +0100
Message-ID: <20121128205656.GC3202@phenom.ffwll.local>
References: <1354041298-18898-1-git-send-email-ville.syrjala@linux.intel.com>
	<1354041298-18898-5-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 4F645E5E11
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 28 Nov 2012 12:55:33 -0800 (PST)
Received: by mail-ee0-f49.google.com with SMTP id c4so6075462eek.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 28 Nov 2012 12:55:32 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1354041298-18898-5-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Nov 27, 2012 at 08:34:58PM +0200, ville.syrjala@linux.intel.com wro=
te:
> From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> As per Chris Wilson's suggestion make
> i915_gem_execbuffer_wait_for_flips() go away.
> =

> This was used to stall the GPU ring while there are pending
> page flips involving the relevant BO. Ie. while the BO is still
> being scanned out by the display controller.
> =

> The recommended alternative is to use the page flip events to
> wait for the page flips to fully complete before reusing the BO
> of the old front buffer. Or use more buffers.
> =

> Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next (with acks from Jesse and Kristian smashed on top),
thanks for the patch. Also dropped the obj->pending_flips removal hunk,
since that's still required.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch