From: "Hans J. Koch" <hjk@hansjkoch.de>
To: Vitalii Demianets <vitas@nppfactor.kiev.ua>
Cc: "Hans J. Koch" <hjk@hansjkoch.de>, Cong Ding <dinggnu@gmail.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] drivers/uio/uio_pdrv_genirq.c: Fix memory leak & confusing labels
Date: Wed, 28 Nov 2012 22:14:07 +0100 [thread overview]
Message-ID: <20121128211407.GC2590@local> (raw)
In-Reply-To: <201211281137.23623.vitas@nppfactor.kiev.ua>
On Wed, Nov 28, 2012 at 11:37:23AM +0200, Vitalii Demianets wrote:
> On Wednesday 28 November 2012 02:37:50 Hans J. Koch wrote:
> >
> > In other words, the case of uioinfo AND pdev->dev.of_node both being NULL
> > is not handled properly and will have ugly results.
> >
>
> Moreover, the case of (uioinfo != NULL) && (pdev->dev.of_node != NULL) leads
> to equally ugly results too (freeing uoinfo when it is statically allocated).
You're right. That wants to be fixed as well.
>
> I think, we should sort out these problems, but in another patch. It is
> totally unrelated to the problem solved by the original patch (memory leak
> caused by not freeing priv in case platform_get_irq() fails).
So far, no patch was applied. I don't mind if all fixes for uio_pdrv_genirq
are in one patch as long as only this one file is altered.
Thanks,
Hans
next prev parent reply other threads:[~2012-11-28 21:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 17:29 [PATCH] drivers/uio/uio_pdrv_genirq.c: Fix memory leak & confusing labels Vitalii Demianets
2012-11-27 23:07 ` Hans J. Koch
2012-11-28 0:07 ` Cong Ding
2012-11-28 0:37 ` Hans J. Koch
2012-11-28 9:29 ` Cong Ding
2012-11-28 21:09 ` Hans J. Koch
2012-11-28 9:37 ` Vitalii Demianets
2012-11-28 21:14 ` Hans J. Koch [this message]
2012-11-29 11:47 ` [PATCH] drivers/uio/uio_pdrv_genirq.c: Fix memory freeing issues Vitalii Demianets
2012-12-04 21:04 ` Hans J. Koch
2012-12-05 9:22 ` [PATCH v2] " Vitalii Demianets
2012-12-06 2:41 ` Hans J. Koch
2012-12-06 9:11 ` Vitalii Demianets
2012-12-06 22:15 ` Hans J. Koch
2012-12-07 9:41 ` Vitalii Demianets
2012-12-07 13:51 ` Vitalii Demianets
2012-12-07 15:00 ` Vitalii Demianets
2012-12-07 23:47 ` Hans J. Koch
2012-12-10 9:03 ` Vitalii Demianets
2012-12-10 9:52 ` Hans J. Koch
2012-12-10 10:24 ` Vitalii Demianets
2012-12-10 22:37 ` Hans J. Koch
2012-12-11 10:47 ` Vitalii Demianets
2012-12-13 17:11 ` Hans J. Koch
2012-12-13 17:23 ` Vitalii Demianets
2012-12-13 17:34 ` Hans J. Koch
2012-12-13 18:00 ` Vitalii Demianets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128211407.GC2590@local \
--to=hjk@hansjkoch.de \
--cc=dinggnu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vitas@nppfactor.kiev.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.