From: Marcelo Tosatti <mtosatti@redhat.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@redhat.com>, Gleb Natapov <gleb@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/2] KVM: VMX: fix invalid cpu passed to smp_call_function_single
Date: Wed, 28 Nov 2012 22:06:02 -0200 [thread overview]
Message-ID: <20121129000602.GB17264@amt.cnet> (raw)
In-Reply-To: <50B6093B.7040404@linux.vnet.ibm.com>
On Wed, Nov 28, 2012 at 08:53:15PM +0800, Xiao Guangrong wrote:
> In loaded_vmcs_clear, loaded_vmcs->cpu is the fist parameter passed to
> smp_call_function_single, if the target cpu is downing (doing cpu hot remove),
> loaded_vmcs->cpu can become -1 then -1 is passed to smp_call_function_single
>
> It can be triggered when vcpu is being destroyed, loaded_vmcs_clear is called
> in the preemptionable context
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
> ---
> arch/x86/kvm/vmx.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2012-11-29 0:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 12:53 [PATCH 1/2] KVM: VMX: fix invalid cpu passed to smp_call_function_single Xiao Guangrong
2012-11-28 12:54 ` [PATCH 2/2] KVM: VMX: fix memory order between loading vmcs and clearing vmcs Xiao Guangrong
2012-11-29 0:04 ` Marcelo Tosatti
2012-11-29 2:04 ` Xiao Guangrong
2012-11-29 3:06 ` Xiao Guangrong
2012-11-29 23:15 ` Marcelo Tosatti
2012-11-29 0:06 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129000602.GB17264@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.