All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2
Date: Thu, 29 Nov 2012 11:18:27 +0000	[thread overview]
Message-ID: <20121129111827.GB22736@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1354128448-12664-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Wed, Nov 28, 2012 at 06:47:28PM +0000, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  drivers/mfd/wm5102-tables.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c
> index 50bbe15..065ffd3 100644
> --- a/drivers/mfd/wm5102-tables.c
> +++ b/drivers/mfd/wm5102-tables.c
> @@ -307,6 +307,7 @@ static const struct reg_default wm5102_reg_default[] = {
>  	{ 0x000001AA, 0x0004 },   /* R426   - FLL2 GPIO Clock */ 
>  	{ 0x00000200, 0x0006 },   /* R512   - Mic Charge Pump 1 */ 
>  	{ 0x00000210, 0x00D4 },   /* R528   - LDO1 Control 1 */ 
> +	{ 0x00000212, 0x0001 },   /* R530   - LDO1 Control 2 */ 

The default for this register is changed in the register patch to
zero should we not leave this setting at zero to match?

  reply	other threads:[~2012-11-29 11:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 18:47 [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2 Mark Brown
2012-11-29 11:18 ` Charles Keepax [this message]
2012-11-29 11:40   ` Mark Brown
2012-11-30 10:20 ` Samuel Ortiz
  -- strict thread matches above, loose matches on Subject: below --
2012-11-28 18:47 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121129111827.GB22736@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.