From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: Patches for v3.8
Date: Thu, 29 Nov 2012 09:09:09 -0500
Message-ID: <20121129140909.GC21184@phenom.dumpdata.com>
References: <20121127213143.GB13890@phenom.dumpdata.com>
	<50B5D83402000078000ABFF1@nat28.tlf.novell.com>
	<alpine.DEB.2.02.1211281150380.5310@kaball.uk.xensource.com>
	<20121128142521.GB21266@phenom.dumpdata.com>
	<1354113142.25834.34.camel@zakaz.uk.xensource.com>
	<20121128144416.GD21266@phenom.dumpdata.com>
	<1354118438.25834.40.camel@zakaz.uk.xensource.com>
	<1354189887.25834.158.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1354189887.25834.158.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, Nov 29, 2012 at 11:51:27AM +0000, Ian Campbell wrote:
> On Wed, 2012-11-28 at 16:00 +0000, Ian Campbell wrote:
> > I'll take a look over the next couple of days.
> 
> Just looking into this now and in
> konrad/stable/pvh.v6:arch/x86/xen/mmu.c in xen_remap_domain_mfn_range we
> have:
> 
> 
> 	if (xen_feature(XENFEAT_auto_translated_physmap))
> 		return -EINVAL;
> 
> ...
> 
> 	if (xen_feature(XENFEAT_auto_translated_physmap)) {
> 		/* We need to update the local page tables and the xen HAP */
> 		return pvh_remap_gmfn_range(vma, addr, mfn, nr, prot, domid, pages);
> 	}
> 
> So it seems like the second one will never be reached...

Yikes! I wonder if I did a mismerge/rebase incorrectly? Mukesh, do you
recall if the original patchset had the first check removed?

> 
> AFAICT this was already the case when support was added in
> de81067d4ef5b434b47f63e11448b3b09cfc0b5e.
> 
> Ian.
>