From: Alban Bedel <alban.bedel@avionic-design.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 2/5] Input: tca8418_keypad - use dev_get_platdata() to retrieve platform data
Date: Thu, 29 Nov 2012 14:48:40 +0100 [thread overview]
Message-ID: <20121129144840.41d5efa8@avionic-0020.adnet.avionic-design.de> (raw)
In-Reply-To: <1352911688-5001-2-git-send-email-dmitry.torokhov@gmail.com>
On Wed, 14 Nov 2012 08:48:05 -0800
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> We need to use proper accessor functions instead of directly poking into
> various structures.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Alban Bedel <alban.bedel@avionic-design.de>
> ---
> drivers/input/keyboard/tca8418_keypad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/tca8418_keypad.c b/drivers/input/keyboard/tca8418_keypad.c
> index 4618ce0..7f2869f 100644
> --- a/drivers/input/keyboard/tca8418_keypad.c
> +++ b/drivers/input/keyboard/tca8418_keypad.c
> @@ -283,7 +283,7 @@ static int __devinit tca8418_keypad_probe(struct i2c_client *client,
> {
> struct device *dev = &client->dev;
> const struct tca8418_keypad_platform_data *pdata =
> - client->dev.platform_data;
> + dev_get_platdata(dev);
> struct tca8418_keypad *keypad_data;
> struct input_dev *input;
> const struct matrix_keymap_data *keymap_data = NULL;
next prev parent reply other threads:[~2012-11-29 13:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 16:48 [PATCH 1/5] Input: tca8418_keypad - use a temporary variable for parent device Dmitry Torokhov
2012-11-14 16:48 ` [PATCH 2/5] Input: tca8418_keypad - use dev_get_platdata() to retrieve platform data Dmitry Torokhov
2012-11-29 13:48 ` Alban Bedel [this message]
2012-11-14 16:48 ` [PATCH 3/5] Input: tca8418_keypad - move device ID tables closer to where they are used Dmitry Torokhov
2012-11-29 13:49 ` Alban Bedel
2012-11-14 16:48 ` [PATCH 4/5] Input: tca8418_keypad - increase severity of failures in probe() Dmitry Torokhov
2012-11-29 13:49 ` Alban Bedel
2012-11-14 16:48 ` [PATCH 5/5] Input: tca8418-keypad - switch to use managed resources Dmitry Torokhov
2012-11-29 13:51 ` Alban Bedel
2012-11-21 7:04 ` [PATCH 1/5] Input: tca8418_keypad - use a temporary variable for parent device Dmitry Torokhov
2012-11-29 13:47 ` Alban Bedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129144840.41d5efa8@avionic-0020.adnet.avionic-design.de \
--to=alban.bedel@avionic-design.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.