All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bill Pemberton <wfp5p@viridian.itc.virginia.edu>
Cc: Michal Marek <mmarek@suse.cz>,
	Fengguang Wu <fengguang.wu@intel.com>,
	devel@driverdev.osuosl.org, Sam Ravnborg <sam@ravnborg.org>,
	linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: [driver-core:driver-core-next 65/93] WARNING: drivers/built-in.o(.text+0xe2399):
Date: Thu, 29 Nov 2012 08:39:22 -0800	[thread overview]
Message-ID: <20121129163922.GA5872@kroah.com> (raw)
In-Reply-To: <20121129155150.5B667801FC@viridian.itc.virginia.edu>

On Thu, Nov 29, 2012 at 10:51:50AM -0500, Bill Pemberton wrote:
> Michal Marek writes:
> > 
> > On 29.11.2012 03:12, Fengguang Wu wrote:
> > > On Wed, Nov 28, 2012 at 02:16:49PM -0800, Greg KH wrote:
> > >> On Thu, Nov 29, 2012 at 05:38:31AM +0800, kbuild test robot wrote:
> > >>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-next
> > >>> head:   da095fd3d5063f2dd03468d71f7df39a0430d86f
> > >>> commit: f791be492f76dea7b0641ed227a60eeb2fa7e255 [65/93] mfd: remove use of __devinit
> > >>> config: x86_64-randconfig-s363 (attached as .config)
> > >>>
> > >>> All warnings:
> > >>>
> > >>> WARNING: drivers/built-in.o(.text+0xe2399): Section mismatch in reference from the function stmpe_i2c_probe() to the function .devinit.text:stmpe_probe()
> > >>> The function stmpe_i2c_probe() references
> > >>> the function __devinit stmpe_probe().
> > >>> This is often because stmpe_i2c_probe lacks a __devinit
> > >>> annotation or the annotation of stmpe_probe is wrong.
> > >>
> > >> Not an issue anymore as __devinit is always defined to nothing, so this
> > >> check doesn't mean anything.
> > 
> > Really? If __devinit was defined to do nothing, then the function would
> > not end up in .devinit.text.
> > 
> 
> Yes, the __dev* #defines are still in init.h right now.  I've not
> touched them yet on the thinking they can't be removed until all users
> of them are gone.
> 
> Maybe it'd be a good idea to change them to nothing now.  That way
> anything that's still using them won't have compile failures, but the
> section mismatches would go away.

Yes, I'll work on that later today.

greg k-h

      reply	other threads:[~2012-11-29 16:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <50b68457.FDmXAd+1Sp92leEs%fengguang.wu@intel.com>
     [not found] ` <20121128221649.GB13534@kroah.com>
2012-11-29  2:12   ` [driver-core:driver-core-next 65/93] WARNING: drivers/built-in.o(.text+0xe2399): Section mismatch in reference from the function stmpe_i2c_probe() to the function .devinit.text:stmpe_probe() Fengguang Wu
2012-11-29  3:04     ` Greg Kroah-Hartman
2012-11-29 15:41     ` Michal Marek
2012-11-29 15:51       ` [driver-core:driver-core-next 65/93] WARNING: drivers/built-in.o(.text+0xe2399): Bill Pemberton
2012-11-29 16:39         ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121129163922.GA5872@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=sam@ravnborg.org \
    --cc=wfp5p@viridian.itc.virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.