All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Anthony Foiani <tkil@scrye.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] v3.0.x: mtd: check partition count not partition array pointer
Date: Thu, 29 Nov 2012 13:38:38 -0800	[thread overview]
Message-ID: <20121129213838.GA20660@kroah.com> (raw)
In-Reply-To: <gpq3oh9on.fsf@dworkin.scrye.com>

On Wed, Nov 07, 2012 at 11:48:24PM -0700, Anthony Foiani wrote:
> 
> mtd: check partition count not partition array pointer
> 
> The documentation claims that "nr_parts" is the determining factor,
> while the code originally tested whether "parts" is non-null.
> 
> In at least one driver (fsl_elbc_nand), parts is never initialized to
> 0; even though nr_parts is correctly 0, add_mtd_partitions still tries
> to create 0 partitions.)
> 
> Make the code adhere to the documentation.
> 
> A quick scan of all uses in the 3.0.51 kernel show that they correctly
> rely on nr_parts rather than parts.
> 
> The current kernel has retired this function; I have not examined its
> replacement to see if it has the same issue.
> 
> Signed-Off-By: Anthony Foiani <anthony.foiani@gmail.com>
> ---
>  drivers/mtd/mtdcore.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

  reply	other threads:[~2012-11-29 21:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-08  6:48 [PATCH 1/1] v3.0.x: mtd: check partition count not partition array pointer Anthony Foiani
2012-11-29 21:38 ` Greg KH [this message]
2012-12-01  0:19   ` Anthony Foiani
2012-12-01  0:32     ` Greg KH
2012-12-01  0:56       ` Anthony Foiani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121129213838.GA20660@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tkil@scrye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.